-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use yaml from config
#112
Only use yaml from config
#112
Conversation
Nice! Thanks for the contribution. 10% speedup in compile time is pretty significant 👍 |
I really like the idea of reducing compile time :D Hence, I just released a new version of comfy-table, which reduces the compile time from 10.7 to 6.5 for that dependency, which is around ~40% in Comfy-table. On top of that, async-timers has been removed and replaced by native async-std timers. This reduces the compile time from 39.1 to 34 sec, which is ~13%. After these changes, we're down from 39.1 to 31, which is ~21%. I'll check if there are some other dependencies that can be removed. |
Well, I just opened a PR with |
The different |
Well, I forgot to update all dependencies before releasing Comfy-Table v1.1. However, this didn't change much in terms of compile time. Looks like strum is too small to make a significant impact. |
I'll be looking around more when I have the time, but I haven't found any easy wins yet since tt looks like everything left is already doing a non-trivial amount of work. I had a decent amount of hope in It is already compiling significantly faster for me now so I'm really glad that you helped out where you could too ❤️ (clean release build is down to 4m 43s on my laptop) These are the results of debug and optimized times from Debug (Total 156s)
Release (Total 423s)
|
I thought about replacing Handlebars as well, since it's a really heavy duty and super feature-rich library. Anyway, I'm really happy with the results. This was actually quite fun :D. Thanks again for helping out 👍 |
I compile this program from the AUR on my pretty weak laptop so I wanted to see if I could slim down compile times a bit. It looks like the only format used from
config
is yaml and restricting it to that gets single job debug compile times from a total of226.72s
to201.65s
and release times from673s
to603s
on a Ryzen 5 1600.