You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If $EDITOR isn't set when running pueue edit, you get an error suggesting that EDITOR isn't set which is nice. However, the task then is locked presumably because the error early returns. This would ideally be handled such that the task is not locked.
Also I'm not sure what the right way to unlock a task, but it seems stash works. I'm not sure if this is documented anywhere.
To Reproduce
unset EDITOR
pueue edit <N>
Expected behavior
Ideally the locked state would be cleared if the editor failed to launch
Additional context
Linux
Pueue version 1.0.4
Also, thanks for the software. Super helpful
The text was updated successfully, but these errors were encountered:
Good point.
I guess it makes sense to unlock the task if either the variable doesn't exist or the editor exits with a non-zero exit code?
For a temporary work-around, you can manually enqueue the task. That way it doesn't stay in that locked state.
Nukesor
changed the title
[BUG] Task locked if on pueue edit if EDITOR not set
[BUG] Task locked on pueue edit if EDITOR environment variable not set
Nov 30, 2021
That is true as well with the exit codes. My inclination would be to only keep it locked if the editor is still running. I guess if the editor died via a signal, you might want it to stay locked, but I'm not sure if trying to handle that scenario is worth the trouble since I'm not sure how reliable the mechanism is to determine whether a child process is killed versus exit with non zero exit code.
Describe the bug
If $EDITOR isn't set when running
pueue edit
, you get an error suggesting that EDITOR isn't set which is nice. However, the task then is locked presumably because the error early returns. This would ideally be handled such that the task is not locked.Also I'm not sure what the right way to unlock a task, but it seems stash works. I'm not sure if this is documented anywhere.
To Reproduce
Expected behavior
Ideally the locked state would be cleared if the editor failed to launch
Additional context
Also, thanks for the software. Super helpful
The text was updated successfully, but these errors were encountered: