-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow ? in path #468
Comments
I think this is an implied assumption that query string params never surface to the path. There isn't something in the spec that prevents you from doing it. Thats the crux l of th problem in the SO post, that u should be able to distinguish diff paths based on query parameters. If we are to support that and consequently rfc 6570 (uri templates) this should absolutely be present. |
The spec definitely doesn't allow it. If it needs to be more explicit in the document, I'll make sure to make it clearer. While some cases should not be checked by the schema, I believe this should be handled by the schema and will be fixed. |
It would be rare if someone puts fragments in path but we should disallow that by not allowing |
I know we spoke about this, but what's the reason for the pushback? Is this not in consideration for the spec vNext? |
It is a consideration for the next version, but it's not in the current one, and the schema represents the current version. :) @mohsen1 - I get your concern, but I'd rather limit for now ? and not fragments, based on how common these issues are. Perhaps in the future, if we see it becoming an issue, we would disallow fragments as well. |
Ron, if it's not a big change, please add |
The spec definitely disallows it. For validation in the schema, that would be handled by tagging it with an appropriate format that enforces the right rules for OAS URL templating, which is being discussed in several places:
I'm going to close this issue in favor of those. While |
Schema should not allow path parameters abused as query parameter like this:
See real world example here: http://stackoverflow.com/a/32658501/650722
The text was updated successfully, but these errors were encountered: