-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] openupgrade_framework : end-migration scripts are forced … #4107
base: 16.0
Are you sure you want to change the base?
[16.0][FIX] openupgrade_framework : end-migration scripts are forced … #4107
Conversation
…to run at install too Fixes OCA#4106
Hi @hbrunn, @StefanRijnhart, @legalsylvain, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the CI errors are unrelated.
do we have any core modules where this is the case in v16? If so, a test for that would be great.
@hbrunn There is no end-migration script for v16 in openupgrade_scripts, but there are 2 files in native Odoo CE :
Can we use those files to run a test ? |
never tried it, but I think it could just work to drop a folder with the module name and correct version into https://github.com/OCA/OpenUpgrade/tree/16.0/openupgrade_scripts/scripts, cf https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_framework/odoo_patch/odoo/tests/loader.py#L30 Edit: ah wait, those are localization modules and those aren't installed in the test database we use. And it must be a newly pulled module anyways. How about adding an end migration script for ie spreadsheet (that's new in v16 and pulled during the migration), check for environment variable OPENUPGRADE_TESTS and if that's set, ie set some config parameter as marker that you can check for in the test? |
Hello @hbrunn Instead of creating an end-migration script in the "production" tree of openupgrade_scripts, I'd like to copy such script during the tests using data.py file... but I'm struggling to get a right path from the Odoo shell. It seems I can't get the value of GITHUB_WORKSPACE... any advice ? |
a38ad4e
to
070a19a
Compare
070a19a
to
16de61e
Compare
just Just to be clear, I don't insist on the test, just thought it was nice |
No idea, sorry. |
so... do we go ahead and merge this? |
OK, please rebase to check the CI. |
H everyone, CI is not OK after rebase, I'll convert this PR to draft for the moment because it seems to me that some others changes in the way odoo is loading modules are preventing post-* and end-* migration scripts to execute for newly installed ones... |
…to run at install too
Fixes #4106