Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] datev_export_xml double entries in xml #161

Closed
david-fleischmann opened this issue May 14, 2024 · 2 comments
Closed

[14.0] datev_export_xml double entries in xml #161

david-fleischmann opened this issue May 14, 2024 · 2 comments
Labels

Comments

@david-fleischmann
Copy link

Module

datev_export_xml

Describe the bug

The datev exort is under certain circumstances having double entries for invoice_item_list

To Reproduce

Trigger xml export of an invoice with configuration "tax_excluded" so only net values are shown in invoice lines.
In the XML file you will have the invoice_item_list entries twice:

image

In my opinion the error is in line 60 not using t-elif, because if in line 51 t-if condition is met it will be resulting in printing again the invoice_item_list from L59
image

Expected behavior
having invoice_item_list just once per line in the xml export.

@fkantelberg
Copy link
Member

Thanks for the notification. I added the commit to the already open PRs #158 #159 and #160 because it's just easier for me than creating more PRs but I can split it into different PRs if you insist.

@david-fleischmann
Copy link
Author

@fkantelberg fine for me, thank you! I will close the issue then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants