Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] fix: stop canceling invoices that are linked to a riba distinta and fix issue #153 #128

Merged
merged 2 commits into from
Mar 9, 2018
Merged

[6.1] fix: stop canceling invoices that are linked to a riba distinta and fix issue #153 #128

merged 2 commits into from
Mar 9, 2018

Conversation

scigghia
Copy link
Contributor

No description provided.

eLBati
eLBati reviewed Jul 30, 2015
View reviewed changes
l10n_it_ricevute_bancarie/account/account.py Outdated

def action_cancel(self, cr, uid, ids, context=None):
if ids:
invoice = self.browse(cr, uid, ids)[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should handle the case where len(ids) is > 1

@eLBati
Copy link
Member

eLBati commented Aug 14, 2015

Ok 👍
Does this problem also occur in 7.0?

@scigghia scigghia changed the title fix: stop canceling invoices that are linked to a riba distinta fix: stop canceling invoices that are linked to a riba distinta na difx issue #153 Oct 28, 2015
@scigghia scigghia changed the title fix: stop canceling invoices that are linked to a riba distinta na difx issue #153 fix: stop canceling invoices that are linked to a riba distinta and fix issue #153 Oct 28, 2015
@scigghia
Copy link
Contributor Author

could be merged?

@scigghia scigghia changed the title fix: stop canceling invoices that are linked to a riba distinta and fix issue #153 [6.1] fix: stop canceling invoices that are linked to a riba distinta and fix issue #153 Feb 18, 2016
@scigghia
Copy link
Contributor Author

@eLBati

@eLBati
Copy link
Member

eLBati commented Feb 18, 2016

Mancherebbe una review e, se la sai, una risposta a #128 (comment)

Per la review puoi chiedere in IRC su #oca o #odoo-it

@eLBati eLBati mentioned this pull request Dec 2, 2016
Closed
@eLBati
Copy link
Member

eLBati commented Jan 18, 2017

Essendo passati + di 6 mesi, chiudo?

@scigghia
Copy link
Contributor Author

Anche se è passato molto tempo, dobbiamo riaprire questa PR
il bug esiste su tutte le versioni di l10n_it_ricevute_bancarie, appena verificato su 8.0
se una fattura presente in distinta riba, viene riaperta e rivalidata, il vecchio riferimento presente in distinta riporterà un bel False al posto del link alla fattura e restituirà errore in fase di accettazione.
bug critico

@eLBati @alessandrocamilli @tafaRU @dcorio @gigidn

@eLBati
Copy link
Member

eLBati commented Apr 21, 2017

@scigghia ok allora ti chiederei di schiacciare i 7 commit in 1 o 2 commit (a seconda di come li vuoi esplicitare), e fare poi la PR anche per 8.0
Poi prendo il commit e lo aggiungo anche a #316

scigghia and others added 2 commits April 21, 2017 16:15
@scigghia
fix: stop canceling invoices that are linked to a riba distinta
9361941 
order by name desc
fixes, eLBati prop.
ids > 0
from tools.translate import _
fix ids > 0
@scigghia
[fix] issue 153 OCA#153
e7d0a59
@scigghia
Copy link
Contributor Author

per 8.0 #321

eLBati
eLBati approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OpenCode pushed a commit to OpenCode/l10n-italy that referenced this pull request May 9, 2017
@pedrobaeza
Merge pull request OCA#128 from eLBati/fix_stock_picking_invoice_link…
d6b178a 
…_copy

[FIX] When trying to duplicate an invoice with related pickings you a…
@eLBati eLBati merged commit fa78b14 into OCA:6.1 Mar 9, 2018
patrickt-oforce pushed a commit to patrickt-oforce/l10n-italy that referenced this pull request Mar 9, 2022
@matteoopenf
Merge pull request OCA#128 from openforceit/11.0-11184-add_gruppi_iva
786a397 
11.0 11184 add gruppi iva
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scigghia @eLBati