Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][l10n_it_ricevute_bancarie] fix compute of tax #2795

Merged

Conversation

patrickt-oforce
Copy link
Contributor

When on an invoice add a line for collecting expenses or bank receipts, set the tax value of that line as defined on the invoice fiscal position tax mapping

Issue #2793

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented Jun 17, 2022

@patrickt-oforce ultima cosa: potresti schiacciare i due commit in uno solo?

@patrickt-oforce patrickt-oforce force-pushed the 14.0-FIX-l10n_it_ricevute_bancarie branch from 7e47ab4 to 0974498 Compare June 17, 2022 08:48
@patrickt-oforce patrickt-oforce requested a review from tafaRU June 22, 2022 07:28
@tafaRU
Copy link
Member

tafaRU commented Jun 22, 2022

@patrickt-oforce dovresti fare rebase per includere la fix di #2836
Se preferisci posso farlo io tramite Oca Bot.

When on an invoice add a line for collecting expenses or bank receipts,
set the tax value of that line as defined on the invoice fiscal position
tax mapping;
Remove unused params values on `map_tax` method call
@patrickt-oforce patrickt-oforce force-pushed the 14.0-FIX-l10n_it_ricevute_bancarie branch from 0974498 to 09d5971 Compare June 23, 2022 07:01
@patrickt-oforce
Copy link
Contributor Author

@tafaRU fatto

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Jun 28, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2795-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3ab1ea6 into OCA:14.0 Jun 28, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f38bd6e. Thanks a lot for contributing to OCA. ❤️

@patrickt-oforce patrickt-oforce deleted the 14.0-FIX-l10n_it_ricevute_bancarie branch August 30, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants