Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable entry of pattern values for date/time types #108

Closed
Stephen-Gates opened this issue Sep 27, 2017 · 3 comments
Closed

Enable entry of pattern values for date/time types #108

Stephen-Gates opened this issue Sep 27, 2017 · 3 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Set-Properties priority:High problem:Bug A bug
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Expected Behaviour

When I choose date, time or datetime types, allow me to enter a format pattern and the pattern values using the allowed syntax

Current Behaviour

I cannot enter a pattern format for date/time data types.

note error is spec: frictionlessdata/datapackage#530

Your Environment

  • Data Curator version 0.3.1
  • Operating System macOS Sierra 10.12.6
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS priority:High problem:Bug A bug labels Sep 27, 2017
@Stephen-Gates Stephen-Gates added this to the v0.3.2 milestone Sep 27, 2017
@Stephen-Gates Stephen-Gates changed the title Enable enter of pattern values for date/time types Enable entry of pattern values for date/time types Sep 27, 2017
@Stephen-Gates Stephen-Gates added the env:Windows This issue is related to running Data Curator on Windows label Sep 28, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.3.2, v0.4.0 Sep 28, 2017
@Stephen-Gates
Copy link
Contributor Author

Required to support validation of Date and Times

Also required when we implement Open Data Package function as the schema may include the pattern option

@Stephen-Gates Stephen-Gates modified the milestones: v0.4.0, v0.3.2 Sep 29, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.3.x, v0.4.0 Oct 3, 2017
@Stephen-Gates
Copy link
Contributor Author

A tester reports, "Couldn’t work out how to fix my validation errors".

image

Note: Type = Date which means ISO8601 date format http://specs.frictionlessdata.io/table-schema/#date

To fix shown errors, need to support date with a format of Pattern

@Stephen-Gates Stephen-Gates modified the milestones: v0.4.0, v0.5.0 Oct 25, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.5.0, v0.7.0 Nov 8, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.7.0, v1.x.x Dec 1, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@ghost ghost added the est:Moderate Moderate effort to implement label Jan 10, 2018
ghost pushed a commit that referenced this issue Jan 19, 2018
@ghost ghost closed this as completed in 8b09ae3 Jan 19, 2018
ghost pushed a commit that referenced this issue Jan 19, 2018
@Stephen-Gates
Copy link
Contributor Author

So what formats are supported?

screenshot 2018-01-19 20 20 26

I wonder if there's a difference between specifying the pattern and validating the pattern?

Should we allow any pattern but warn if we can't vaildate?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Set-Properties priority:High problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

1 participant