Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable entry of trueValues and falseValues for Boolean values #109

Closed
Stephen-Gates opened this issue Sep 27, 2017 · 9 comments
Closed

Enable entry of trueValues and falseValues for Boolean values #109

Stephen-Gates opened this issue Sep 27, 2017 · 9 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows f:Feature-request This issue is a request for a new feature fn:Set-Properties priority:Medium
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Sep 27, 2017

Expected Behaviour

When I choose boolean as a Type, allow me to enter trueValues and falseValues

Current Behaviour

I cannot enter trueValues and falseValues

screenshot 2017-09-28 00 49 39

Your Environment

  • Data Curator version 0.3.1
  • Operating System macOS Sierra 10.12.6
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS priority:High problem:Bug A bug labels Sep 27, 2017
@Stephen-Gates Stephen-Gates added this to the v0.3.2 milestone Sep 27, 2017
@Stephen-Gates Stephen-Gates added the env:Windows This issue is related to running Data Curator on Windows label Sep 28, 2017
@ghost
Copy link

ghost commented Sep 28, 2017

Sorry @Stephen-Gates
Not sure what you mean. Atm, it just sets type without controlling what you can enter in the spreadsheet.

@Stephen-Gates
Copy link
Contributor Author

The spec says,

boolean

The field contains boolean (true/false) data.

In the physical representations of data where boolean values are represented with strings, the values set in trueValues and falseValues are to be cast to their logical representation as booleans. trueValues and falseValues are arrays which can be customised to user need. The default values for these are in the additional properties section below.

The boolean field can be customised with these additional properties:

  • trueValues: [ "true", "True", "TRUE", "1" ]
  • falseValues: [ "false", "False", "FALSE", "0" ]

format: no options (other than the default).

So I assume we need two input fields to accept trueValues and falseValues.

@Stephen-Gates Stephen-Gates modified the milestones: v0.3.2, v0.4.0 Sep 28, 2017
@Stephen-Gates
Copy link
Contributor Author

Required when we implement Open Data Package function as the schema may include the trueValues and falseValues option

@Stephen-Gates Stephen-Gates modified the milestones: v0.4.0, v0.5.0 Oct 11, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.5.0, v0.7.0 Nov 8, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.7.0, v1.x.x Dec 1, 2017
@Stephen-Gates Stephen-Gates added priority:Medium f:Feature-request This issue is a request for a new feature and removed problem:Bug A bug priority:Medium labels Dec 13, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, v1.9.0 Jan 10, 2018
@Stephen-Gates
Copy link
Contributor Author

/remind me to draft the user interface and acceptance tests on 18 April

@reminders reminders bot added the reminder label Mar 28, 2018
@reminders

This comment has been minimized.

@Stephen-Gates
Copy link
Contributor Author

Thoughts on user interface:

If type is boolean, allow entry of:

  • An array of trueValues - default vales are [ "true", "True", "TRUE", "1" ]
  • An array of falseValues - default vales are [ "false", "False", "FALSE", "0" ]

On screen help to guide input of values and show default values

@reminders reminders bot removed the reminder label Apr 18, 2018
@reminders

This comment has been minimized.

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented May 1, 2018

Acceptance test

@ghost
Copy link

ghost commented May 2, 2018

Add input text box showing default values, which user can change.
Ensure this is sent with validation,export, etc.
Put input box between type and format.

ghost pushed a commit that referenced this issue May 8, 2018
@ghost ghost closed this as completed May 8, 2018
ghost pushed a commit that referenced this issue May 8, 2018
ghost pushed a commit that referenced this issue May 9, 2018
ghost pushed a commit that referenced this issue Apr 21, 2021
ghost pushed a commit that referenced this issue Apr 21, 2021
ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows f:Feature-request This issue is a request for a new feature fn:Set-Properties priority:Medium
Projects
None yet
Development

No branches or pull requests

1 participant