null Sources properties written to datapackage.json

[Stephen-Gates]

Expected Behaviour (for problems)

properties without values entered in the properties panel are not written to datapackage.json

Current Behaviour

data package sources properties without values entered in the properties panel are written to datapackage.json

Steps to Reproduce

When reporting a problem, provide a set of steps so others can reproduce the problem.

1. Create a data package - don't enter optional or recommended property values
2. Export data package
3. Inspect datapackage.json

Your Environment

• Data Curator version 0.5.0
• Operating System and version macOS High Sierra 10.13

[Stephen-Gates]

Nulls in the Sources property is invalid. The spec states that each Source must have a title.

[ghost]

@Stephen-Gates,
So does that rule (ie: source must be present and must have at least title) also apply to each table?

[Stephen-Gates]

Yes https://frictionlessdata.io/specs/data-resource/#optional-properties

[Stephen-Gates]

@mattRedBox Sources is optional as a whole but if it has any values it must include a title.

This validation is too strict

[ghost]

Hi @Stephen-Gates
Just tested this again and I put in the requirement because of the return from frictionless libraries. of error message:

"Descriptor validation error:
Array is too short (0), minimum 1
at "/sources" in descriptor and
at "/properties/sources/minItems" in profile"

if either table or package does not have any sources.

[Stephen-Gates]

thanks @mattRedBox can you raise an issue for that as it appears to clash with the spec

[ghost]

Sorry - that one's on me :P
We were sending through an empty array of sources, so json validation at frictionless end was simply reporting cannot have empty array.