Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique constraint is not validated #311

Closed
Stephen-Gates opened this issue Dec 7, 2017 · 7 comments
Closed

Unique constraint is not validated #311

Stephen-Gates opened this issue Dec 7, 2017 · 7 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Validation priority:High problem:Bug A bug status:Blocked 😢 We can't progress this until something else happens
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Dec 7, 2017

Current Behaviour (for problems)

Expected Behaviour

  • error detected

Your Environment

  • Data Curator version: 0.7.0
  • Operating System and version: e.g. macOS High Sierra 10.13.1
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS fn:Validation problem:Bug A bug labels Dec 7, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.8.0, v1.x.x Dec 7, 2017
@Stephen-Gates Stephen-Gates added priority:High env:Windows This issue is related to running Data Curator on Windows labels Dec 13, 2017
@Stephen-Gates Stephen-Gates changed the title unique constraint not tested Unique constraint not tested Dec 31, 2017
@Stephen-Gates Stephen-Gates changed the title Unique constraint not tested Unique constraint is not validated Dec 31, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@Stephen-Gates
Copy link
Contributor Author

@ghost
Copy link

ghost commented Jan 11, 2018

Hi @Stephen-Gates
In investigating this, I also noticed that while I can get multiple errors back from the same row.
I cannot get multiple errors back from same cell from tableschema.js - do we care about this?

i.e., The fact that the cell reports 1 error is enough, and that can be fixed, before the next one comes through - so we don't need it to report that multiple errors exit on the cell, just that there's an error is enough.
Put another way: a cell only seems to report 1 error at a time.
You can test this by say putting in a minimum constraint and a 'required' constraint say on a blank cell of field: integer.

@Stephen-Gates
Copy link
Contributor Author

@mattRedBox I think that's ok.

/remind me to add Data Curator only reports 1 error per cell to the docs in 3 months time

@reminders reminders bot added the reminder label Jan 11, 2018
@reminders
Copy link

reminders bot commented Jan 11, 2018

@Stephen-Gates set a reminder for 04/11/2018

@ghost
Copy link

ghost commented Jan 31, 2018

Tested changes successfully in our code needed for
frictionlessdata/tableschema-js#124
to get all row errors and also show unique constraints.

@Stephen-Gates Stephen-Gates modified the milestones: v0.9.0, v0.10.0 Feb 1, 2018
@ghost ghost added the status:Blocked 😢 We can't progress this until something else happens label Feb 12, 2018
@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Feb 13, 2018

@mattRedBox https://github.com/frictionlessdata/tableschema-js/releases/tag/v1.7.0 is out.

Suggest this is now unblocked and can be included in 0.10.0 build?

GitHub
tableschema-js - A JavaScript library for working with Table Schema.

@ghost
Copy link

ghost commented Feb 14, 2018

Fixed with 1.7.0 release
Nice work @roll

@ghost ghost closed this as completed Feb 14, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Validation priority:High problem:Bug A bug status:Blocked 😢 We can't progress this until something else happens
Projects
None yet
Development

No branches or pull requests

1 participant