Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close Tab doesn't warn that changes are unsaved #68

Closed
Stephen-Gates opened this issue Sep 9, 2017 · 4 comments
Closed

Close Tab doesn't warn that changes are unsaved #68

Stephen-Gates opened this issue Sep 9, 2017 · 4 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature fn:Close-Quit priority:High
Milestone
Support release

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Sep 9, 2017 •
edited
Loading

Expected Behaviour

https://app.cucumber.pro/projects/data-curator/documents/branch/develop/test/features/file/close-tab.feature

Current Behaviour

Close Tab closes the tab without warning that the work is unsaved

Steps to Reproduce (for problems)

  1. Enter some data
  2. Press the close button on the active tab
  3. Tab with unsaved work is closed

Your Environment

  • Data Curator 0.2.3
  • Operating System macOS Seirra 10.12.6
@Stephen-Gates Stephen-Gates added this to the v0.3.0 milestone Sep 9, 2017
@Stephen-Gates Stephen-Gates assigned ghost Sep 9, 2017
@Stephen-Gates Stephen-Gates added the env:MacOS This issue is related to running Data Curator on macOS label Sep 18, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.3.0, v0.4.0 Sep 21, 2017
@Stephen-Gates Stephen-Gates added fn:Close-Quit env:Windows This issue is related to running Data Curator on Windows labels Oct 3, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.4.0, v0.5.0 Oct 11, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.5.0, v0.7.0 Nov 8, 2017
@Stephen-Gates Stephen-Gates mentioned this issue Dec 1, 2017
Closed
@Stephen-Gates Stephen-Gates modified the milestones: v0.7.0, v0.8.0, v1.x.x Dec 7, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, v0.12.0 Feb 14, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.12.0, v1.x.x Mar 15, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, v0.17.0 Mar 30, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.17.0, v1.1.0 Apr 14, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v1.1.0, v0.17.0, v0.18.0 Apr 14, 2018
@Stephen-Gates
Copy link
Contributor Author

Consider implementing with #67 as additional effort is minor

@Stephen-Gates Stephen-Gates added f:Feature-request This issue is a request for a new feature and removed problem:Bug A bug labels Apr 28, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.18.0, v1.x.x Apr 28, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, Backlog May 11, 2018
@Stephen-Gates Stephen-Gates mentioned this issue Jun 7, 2019
Closed
@Stephen-Gates Stephen-Gates modified the milestones: Backlog, Support release Jun 7, 2019
@ghost ghost added est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) and removed est:Minor Minor effort to implement labels Jun 26, 2019
@Stephen-Gates
Copy link
Contributor Author

@mattRedBox I was able to add data in first tab, create new tab, delete first tab without warning showing

@Stephen-Gates
Copy link
Contributor Author

d'Oh you haven't fixed this - I'll test the closed issues!!!

@ghost ghost closed this as completed in 5e36b3f Jul 5, 2019
ghost pushed a commit that referenced this issue Jul 5, 2019
Closes #68.
93241f8
@Stephen-Gates
Copy link
Contributor Author

Fixed in v1.1

ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #68: Moved closed tab to interact with main to prompt for clos…
442b097 
…e and send back tab id.
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #68.
6b2bd5e
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature fn:Close-Quit priority:High
Projects
None yet
Milestone
Support release
Development

No branches or pull requests
1 participant
@Stephen-Gates