Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 0x0 mm Measurements from SRs that Span Multiple Series #3673

Closed
03shek opened this issue Sep 22, 2023 · 3 comments
Closed

[Bug] 0x0 mm Measurements from SRs that Span Multiple Series #3673

03shek opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@03shek
Copy link

03shek commented Sep 22, 2023

Describe the Bug

Loading SRs created from OHIF, but that spans multiple series, sometimes results in 0x0 mm measurements.

Steps to Reproduce

  1. Add a measurement from Series 1.
  2. Track Series 1 when prompted.
  3. Add a measurement from Series 2.
  4. "Add to existing report" when prompted.
  5. Create SR Report.
  6. All measurements can be read and navigated to in this study session.
  7. Reload the study entirely with CTRL+F5.
  8. Load the saved SR and say Yes to continue tracking measurements.
  9. All measurements in list seem non-zero.
  10. Start working your way down the measurement list, clicking each measurement one by one.
  11. Upon clicking a Series 2 measurement, it turns to 0x0 mm and there are no annotation visible in the viewport. The session has crashed.

The current behavior

Not all measurements can be read and navigated to from an SR that includes measurements from multiple series.

The expected behavior

All measurements should be readable and navigated to from an SR that includes measurements from multiple series, since its creation is allowed in OHIF.

OS

OHIF demo local

Node version

OHIF demo local

Browser

Chrome 117.0.0

@03shek 03shek added the Awaiting Reproduction Can we reproduce the reported bug? label Sep 22, 2023
@03shek 03shek changed the title [Bug] [Bug] 0x0 mm Measurements from SRs that Span Multiple Series Sep 22, 2023
@jbocce
Copy link
Contributor

jbocce commented Oct 4, 2023

I was able to reproduce a similar problem with the steps outlined above. I never saw "0x0 mm". However, did see the values and units completely disappear. A couple of PRs will be available soon to fix this.

@jbocce
Copy link
Contributor

jbocce commented Oct 4, 2023

See OHIF PR #3696 and CS3D PR #810

@jbocce
Copy link
Contributor

jbocce commented Oct 4, 2023

Note that after hydrating certain measurements (e.g. ellipse ROI) that are on different series, the units may not appear until navigated to. I will create a separate issue for this to be handled in a future release.

@sedghi sedghi closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

3 participants