[Bug] 3.8 recovery

[sedghi]

Describe the Bug

Here are the bugs that need to be fixed in the 3.8.1 release

• tmtv cannot use the threshold tool
• Segmentation Panel Will not add a new segmentation if Layout is changed [Bug] #4046
• [Bug] Volume rendering broken if using DICOM JSON data source #4081
• UI bug in Segmentation panel "Segmentation List" panel does not display all segmentations in list - 3.9.0-beta.6 [Bug] #4132
• feat(typings): Enhance typing support with withAppTypes and custom services throughout OHIF #4090
• THe tmtv issue when sometimes the fusion has wrong inverted
• Switching between two SEGs causes hanging protocol button to become unresponsive (3.9.14)[Bug] #4158

[sedghi]

Threshold tool tmtv does not work

[sedghi]

#4081

[sedghi]

Add the types

[sedghi]

#4132

[tzuccher]

INTERMITTENT **3.8.1 Bug Found while trying to reproduce #4046 - did not even get as far as the steps in 4046 *at this point i would fail 4046 in the current build i am testing with the following steps:
Segmentation Mode Select Add Segmentation = Black Viewports

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select study CT/SEG HCC_004 and select the Segmentation button
2. From the viewer page, select the Add Segmentation verbiage in the right-side panel = black viewports that i cannot scroll or do anything with them
3. When i try and scroll within one of the black viewports there is an uncaught error in the console that accumulates as i scroll
   
   **this is repeatable for SEG studies as well as non-seg studies

[tzuccher]

INTERMITTENT **3.8.1 Bug Found while testing 4132:
Segmentation Mode drag in SEG series = black viewport where I cannot see the image or existing segmentations

Note: this issue is blocking me from testing #4132

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select a SEG study and select the Segmentation button to go to the viewer screen - i used PCAMPMRI...
2. Scroll to the bottom of the study panel and dragged the last SEG item into viewport C - clicked yes = all 4 viewports went black
3. Clicking in viewport C = errors in console
   

[tzuccher]

Note that selecting a SEG study with the Basic Viewer mode (instead of the Segmentation mode), and then dragging in the SEG item into a viewport still produced a black viewport but, i was able to select a different layout option that seemed to produce images. After this, i was able to load in Segmentation mode without getting the black viewports - not sure what these steps did to help resolve the2 issues above that i reported...

[tzuccher]

Testing #4046 now that i can get the SEG to work again... (with 3.8.1 testing: 3.8.1, Commit hash:
1dcdc9d)
As described in the issue, using study WaterPhantom, there seems to be no issue or with study ACRIN ... with 934 instances.

#4046 appears to be ok if you can get around the black viewports reported above

#4132 - also looks better when you can get around the black viewports issue

#4158 - also looks good when you don't have the black viewports issue

Note that i was able to get the black viewport issue to happen again by repeating the steps above intermittently. It is still there in the background and i think needs to be resolved.

[tzuccher]

new issue?
Segmentation mode: within the viewport zoom in on the image = can no longer add segment shapes to any images

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select a study and the Segmentation button
2. Click into a viewport, select Add Segment verbiage
3. Select brush and create shapes on image
4. Zoom in on the image
5. Select the brush tool again and attempt to create a shape on the same or different viewport = i can no longer create shapes
   

[sedghi]

https://ohif-viewer-381-rc2.netlify.app/

[tzuccher]

Test results from initial view from: https://ohif-viewer-381-rc2.netlify.app/
Note: opened a new Chrome Incognito window for each issue being verified

Issue: tmtv cannot use the threshold tool
Pass with the following steps:

1. Select study: ACRIN...with 934 instances and selected the Total Metabolic Volume button
2. Clicked into the PT axial viewport
3. Selected the Rectangle ROI Threshold tool and created shape on image = was able to create shape without receiving Something Went Wrong message
4. Selected Add segmentation verbiage
5. Selected Run button = created red shading on all viewports, in area where the rectangle was created on the PT axial viewport

Issue: #4046
RESULT = Failed testing with the following steps for two scenarios
4046 Scenario One

1. Select study: Water Phantom and select the Segmentation button
2. From the 2x2 layout with Viewport A active, select the +Add segmentation verbiage = nothing happens and there is an uncaught error in the console
   ** IMPORTANT NOTE: after you select the Add segmentation verbiage and get nothing (but errors in the console), if you click the verbiage again (once, might need to select another time...) the Segment is finally created! I am still failing due to the fact that you have to select more than once for it to work.
   

4046 Scenario Two

1. Select study CT/SEG HCC_004 and select the Segmentation button
2. From the viewer page, select the Add Segmentation verbiage in the right-side panel = also same as above, nothing happens with uncaught error in the console
   

Issue #4132
RESULT = Passed with the following steps:

1. Select a SEG study and select the Segmentation button to go to the viewer screen - I used PCAMPMRI...
2. Scroll to the bottom of the study panel and drag the last SEG item into viewport C - clicked yes = all 4 viewports filled accordingly with the images + existing segmentations
3. I was able to repeat step 2 for all three seg items in the study panel
4. Selected the Segmentation drop-down menu and all 3 seg items appeared and I could select them successfully
5. Was also able to add a new segment without issue
6. I also went back to the study list page and selected the same study in basic viewer mode = I was able to drag into the active viewport the SEG items & view them without issue

Issue #4158
RESULT = passed with the following steps:

1. load T2 Weighted Axial Segmentation = displays with segmentation panel populated
2. load DCE Subtraction Segmentation = displays with segmentation panel populated
3. load Apparent Diffusion ... item = displays with a segmentation panel populated
4. on the segmentation panel, load the segmentation dropdown, see all 3 options and select each.
5. Select the Layout tool menu and select different options = the screen layout will change without error no matter what option is selected

[sedghi]

Thanks, can you check this one now https://ohif-viewer-381-rc3.netlify.app/

[tzuccher]

Retested the noted issues and all steps noted pass with the latest build in rc3: https://ohif-viewer-381-rc3.netlify.app/

Tested the following with passing results (steps noted in comment above) on a mac (sonoma 14.5) + chrome browser (v125)

1. Passed Issue: tmtv cannot use the threshold tool
2. Passed Issue: Segmentation Panel Will not add a new segmentation if Layout is changed [Bug] #4046
3. Passed Issue UI bug in Segmentation panel "Segmentation List" panel does not display all segmentations in list - 3.9.0-beta.6 [Bug] #4132
4. Passed Issue Switching between two SEGs causes hanging protocol button to become unresponsive (3.9.14)[Bug] #4158
5. Passed new issue recorded May 30th (above): Segmentation mode: within the viewport zoom in on the image = can no longer add segment shapes to any images

[tzuccher]

Additional issues noted that required new rc builds:

1. Capture tool was not displaying image (fixed in rc4)
2. US study: Cardiac US images were red in the basic viewer (fixed in rc5)

[tzuccher]

New issue found on ohif-viewer-381-rc5, 3.8.1 Commit hash: 1dcdc9dabe9d4179f223912d6adc00bc95629a85on a mac (sonoma 14.5) + chrome browser (v125) - https://ohif-viewer-381-rc5.netlify.app/

TMTV MIP image lost when rectangle ROI is created & run twice and then MIP rotated
Steps to recreate:

1. Select ACRIN...with 934 instances and the TMTV button
2. Clicked into the PT axial image and created a Rectangle ROI shape
3. Pressed Add segmentation verbiage and then the Run button = the shape filled with red shading as expected
4. Clicked on MIP, rotated and double-clicked to go into 1x1 - double-clicked again to go into TMTV layout
5. Created a new rectangle shape on PT axial and clicked Run button again = the red shading changed to the new rectangle
6. Clicked on the Add segmentation verbiage = Segmentation 2 displayed but also noticed the MIP moved a bit within the viewport
7. Clicked on the MIP image to rotate and it disappeared from the viewport
   

[sedghi]

As discussed we will address these in the next version