Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: external link wrapped around element not working #35

Closed
danryland opened this issue Jul 16, 2024 · 1 comment · Fixed by #36 · May be fixed by #37
Closed

bug: external link wrapped around element not working #35

danryland opened this issue Jul 16, 2024 · 1 comment · Fixed by #36 · May be fixed by #37

Comments

@danryland
Copy link
Contributor

danryland commented Jul 16, 2024

External links, when wrapped around images, don't work. External links that are just text work. This is because the check for ev.target.href doesn't have an href because the element in question is the img. Any element wrapped in an a tag should still work. See screenshots below.

How to reproduce

  1. Navigate to https://community.projectkamp.com/academy/support/merch
  2. Tap on the 'Spikey Booshes Download' image (This is wrapped in an a)
  3. Note that nothing happens
  4. Tap on the alternative 'Download here' link and it works as expect

Added console.log to see what was being targetted:

Screenshot 2024-07-16 at 13 40 11

See img vs a tag being returned from the console.log

Screenshot 2024-07-16 at 13 40 03
@danryland
Copy link
Contributor Author

Created pull request to fix the issue #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant