Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off TLS verification from env variable #290

Open
SleepingShell opened this issue Sep 15, 2020 · 2 comments
Open

Allow turning off TLS verification from env variable #290

SleepingShell opened this issue Sep 15, 2020 · 2 comments
Labels
feature request Issues that request new features to be added to OnlyOffice

Comments

@SleepingShell
Copy link

SleepingShell commented Sep 15, 2020

Do you want to request a feature or report a bug?
feature

What is the current behavior?
You must edit the /etc/onlyoffice/documentserver/default.json to set rejectUnauthorized, however editing this file does not do anything when the server is already running as a container.

What is the expected behavior?
Have an environment variable that can set 'rejectUnauthorized' to false before the document server is actually started.

Did this work in previous versions of DocumentServer?
No, this has been discussed in #96 . The suggested workaround on that issue is to rebuild the docker image every update with the edited file, but that is not very feasible.

@SleepingShell SleepingShell changed the title Allow turning of TLS verification from env variable Allow turning off TLS verification from env variable Sep 15, 2020
@ShockwaveNN
Copy link
Contributor

Hi

The suggested workaround on that issue is to rebuild the docker image every update with the edited file

I may be wrong, but rebuilding of image every update is not needed if used like I described here
#96 (comment)

But in general - I agree, specific option for this would be great. @agolybev any thoughts?

@ShockwaveNN ShockwaveNN added the feature request Issues that request new features to be added to OnlyOffice label Sep 16, 2020
@SleepingShell
Copy link
Author

SleepingShell commented Sep 16, 2020

Hi

The suggested workaround on that issue is to rebuild the docker image every update with the edited file

I may be wrong, but rebuilding of image every update is not needed if used like I described here
#96 (comment)

But in general - I agree, specific option for this would be great. @agolybev any thoughts?

You're right I didn't try that solution due to the one person saying it didn't work, but it I can confirm that solution works (although needs to be updated with new directory names). Although it is definitely hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to OnlyOffice
Projects
None yet
Development

No branches or pull requests

2 participants