Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current validation rules only for BT-131(d) and BT-132(d) allow inconsistencies in BT-131(t)/BT-132(t) #783

Open
gabrieledall opened this issue Dec 11, 2023 · 8 comments
Assignees
Labels
efx-toolkit Related to the EFX Toolkit Java library validation Related to notice validation.

Comments

@gabrieledall
Copy link

The validation rules that make sure,any opening of tenders in open procedurese will take place after the end of the submission deadline is reached are currently inmplemented in a way that is not fully consitent:

Currently (at least from SDK 1.72 to 1.10.0) BT-132(d) ist validated according to BT-131(d) as follows:

"condition" : "{ND-PublicOpening} ${(BT-132(d)-Lot is present) and (BT-131(d)-Lot is present)}",
"value" : "{ND-PublicOpening} ${BT-132(d)-Lot >= BT-131(d)-Lot}",

iIt is allowed to have open procedures to be opended on the same day, the submission deadline is reached - this is fine and please do not change this rule, but then:

Opening time and submission time are set separately in BT-131(t) and BT-132(t) and no validation check is implemented to the time-related fields. this makes it ist possible to hand in CNs like this:

BT-131(d) = 11.12.2023 UTC+1:00
BT- 132(d) = 11.12.2023 UTC +1:00

BT-131(t) = 18:00 UTC +1:00
BT-132(t) = 12:00 UTC +1:00

Which would make the opening date/time earlier than the submission deadline date/time.

Could you please correct this issue with a next patch-release of at least SDK-1.10?

Thank you in advance
G.D.

@YvesJo YvesJo self-assigned this Dec 11, 2023
@YvesJo YvesJo added efx-toolkit Related to the EFX Toolkit Java library validation Related to notice validation. labels Dec 11, 2023
@YvesJo
Copy link
Contributor

YvesJo commented Dec 11, 2023

Hi,
This control is restricted by the current EFX language and shall get fixed with EFX 2.

@Colan71
Copy link

Colan71 commented Apr 4, 2024

Hi,
The rule for BT-132(d) in comparison with BT-131(d) is unclear.
We can see in the fields.json for the conditions regarding BT-132(d)-Lot that the error message for rule|text|BR-BT-00132-0151 is 'Opening date' (BT-132) must be later than 'Deadline for receipt of tenders' (BT-131). Still we can validate a notice successfully even though BT-131(d) and BT-132(d) have the exact same date and time. Should this be the case? If so, will you then remove the rule for BT-132(d)-Lot in an upcoming SDK?

@YvesJo
Copy link
Contributor

YvesJo commented Apr 4, 2024

This will be the case until EFX2 will be available

@Colan71
Copy link

Colan71 commented Apr 4, 2024

Just to get this crystal clear :) Does this mean that when EFX2 is available there will also be a time validation for BT-131(d) and BT-132(d). So they can still have the same date, but the time for BT-132(d) must be later than the time in BT-131(d)?

@YvesJo
Copy link
Contributor

YvesJo commented Apr 5, 2024

Yes, it will be possible to compare date-time values from the date and time ones.

@Colan71
Copy link

Colan71 commented Apr 5, 2024

And the timeline for EFX2 is pre-releases during 2024 as you progress and a final release Q1 2025, right?

@Colan71
Copy link

Colan71 commented Jun 27, 2024

Hi,
Can you please inform us when the time validation will be in place?

@pdonohoe
Copy link
Contributor

pdonohoe commented Jul 2, 2024

The time validation is also dependent on EFX2, so it would not be fully implemented until Q1 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efx-toolkit Related to the EFX Toolkit Java library validation Related to notice validation.
Projects
None yet
Development

No branches or pull requests

4 participants