Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rule texts in GR-LotResult-ReceivedSubmissions #960

Open
GarrusMD opened this issue Jun 13, 2024 · 6 comments
Open

Wrong rule texts in GR-LotResult-ReceivedSubmissions #960

GarrusMD opened this issue Jun 13, 2024 · 6 comments
Assignees
Labels
translations About labels and translations
Milestone

Comments

@GarrusMD
Copy link

GarrusMD commented Jun 13, 2024

Some rule texts within the GR-LotResult-ReceivedSubmissions group are incorrect. The rule texts refer to BTs that do not (or no longer?) exist. In englisch at least the following text is wrong:

rule|text|BR-BT-13713-0102">If received tenders micro (BT-1481) is not empty, BT-1482 (BT-1482) is not empty and BT-1483 (BT-1483) is not empty, then BT-148 (BT-148) must be equal to the sum of BT-1481 (BT-1481), BT-1482 (BT-1482) and BT-1483 (BT-1483)

In the german translation at least the following texts refer to wrong BTs:

BR-BT-13713-0101">'Eingegangene Angebote oder Teilnahmeanträge' (BT-146) darf nicht niedriger sein als die Summe der eingegangenen unzulässigen Angebote (BT-741) und der eingegangenen nicht geprüften Angebote (BT-742)
BR-BT-13713-0102">Wenn erhaltene Angebote Mikro (BT-1481) nicht leer ist, ist BT-1482 (BT-1482) nicht leer und ist BT-1483 (BT-1483) nicht leer, dann muss BT-148 (BT-148) gleich der Summe aus BT-1481 (BT-1481), BT-1482 (BT-1482) und BT-1483 (BT-1483) sein
BR-BT-13713-0103">Angebote von KMU (BT-148) müssen niedriger oder gleich sein wie eingegangene Angebote (BT-146)
Erhaltene Angebote aus anderen EU-Ländern als dasjenige des Käuferwertes müssen niedriger oder gleich den eingegangenen Angeboten (BT-146) sein
BR-BT-13713-0103">Angebote von KMU (BT-148) müssen niedriger oder gleich sein wie eingegangene Angebote (BT-146)

The texts are also all attached to the field "BT-13713-LotResult". Wouldn't it be better to attach the rules directly to the GR-LotResult-ReceivedSubmissions group?

@YvesJo YvesJo self-assigned this Jun 14, 2024
@YvesJo
Copy link
Contributor

YvesJo commented Jun 14, 2024

Thanks,
This issue is already known and was prepared for SDK 1.10 (#532), updates were somehow lost.
We'll fix it asap, either in SDK 1.12 or with the next labels update. This will also get applied to previous versions.

@YvesJo YvesJo added the translations About labels and translations label Jun 14, 2024
@YvesJo YvesJo added this to the SDK 1.12.0 milestone Jun 14, 2024
@GarrusMD
Copy link
Author

Thanks :)

@YvesJo YvesJo closed this as completed Jul 22, 2024
@GarrusMD
Copy link
Author

Hi @YvesJo the german translation in SDK 1.12 still refers to BTs that no longer exist: At least in BR-BT-13713-0101, BR-BT-13713-0103, BR-BT-13713-0104, BR-BT-13713-0105 and BR-BT-13713-0106.

@YvesJo
Copy link
Contributor

YvesJo commented Jul 22, 2024

Hi,
The rules were expressed using Business Terms IDs and not fields IDs. rule|text|BR-BT-13713-0102 in its previous state was not understandable and has been fixed, other rules could be expressed referencing Fields IDs instead when you think this really adds value in which case this would be done for SDK 1.13.

@GarrusMD
Copy link
Author

It would help to display the correct BTs. The correct BTs are also displayed in the English version.

@YvesJo
Copy link
Contributor

YvesJo commented Jul 22, 2024

Ok, I'll have a closer look at it.
I reopen that ticket and associate it to SDK 1.13 regarding the remaining rules

@YvesJo YvesJo reopened this Jul 22, 2024
@YvesJo YvesJo modified the milestones: SDK 1.12.0, SDK 1.13.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations About labels and translations
Projects
None yet
Development

No branches or pull requests

2 participants