Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat-ls: Add support for armv8 platform flavours #1787

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

b49020
Copy link
Contributor

@b49020 b49020 commented Sep 4, 2017

Added support for armv8 platform flavours as follows:

  • PLATFORM = ls-ls1043ardb
  • PLATFORM = ls-ls1046ardb

Signed-off-by: Sumit Garg sumit.garg@nxp.com

@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments below.
In any case:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

.travis.yml Outdated
- $make PLATFORM=ls-ls1021atwr
- $make PLATFORM=ls-ls1021aqds

# Layerscape ls1043ardb (ARMv8A)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the correct (official) spelling is ARMv8-A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it.

MAINTAINERS.md Outdated
| FSL ls1021a |`Sumit Garg <sumit.garg@freescale.com>`|
| FSL ls1021a |`Sumit Garg <sumit.garg@nxp.com>`|
| NXP ls1043ardb |`Sumit Garg <sumit.garg@nxp.com>`|
| NXP ls1046ardb |`Sumit Garg <sumit.garg@nxp.com>`|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor:
I'm a bit confused about naming here. You replaced FSL with Layerscape in .travis.yml, and here you're introducing a mix of FSL and NXP. Should that be NXP Layerscape ls1021a, NXP Layerscape ls1043ardb etc. maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will fix it.

Added support for armv8 platform flavours as follows:
- PLATFORM = ls-ls1043ardb
- PLATFORM = ls-ls1046ardb

Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
@jforissier jforissier merged commit 2b9f239 into OP-TEE:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants