-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plat-ls: Add support for armv8 platform flavours #1787
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments below.
In any case:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
.travis.yml
Outdated
- $make PLATFORM=ls-ls1021atwr | ||
- $make PLATFORM=ls-ls1021aqds | ||
|
||
# Layerscape ls1043ardb (ARMv8A) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: the correct (official) spelling is ARMv8-A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it.
MAINTAINERS.md
Outdated
| FSL ls1021a |`Sumit Garg <sumit.garg@freescale.com>`| | ||
| FSL ls1021a |`Sumit Garg <sumit.garg@nxp.com>`| | ||
| NXP ls1043ardb |`Sumit Garg <sumit.garg@nxp.com>`| | ||
| NXP ls1046ardb |`Sumit Garg <sumit.garg@nxp.com>`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
I'm a bit confused about naming here. You replaced FSL with Layerscape in .travis.yml
, and here you're introducing a mix of FSL
and NXP
. Should that be NXP Layerscape ls1021a
, NXP Layerscape ls1043ardb
etc. maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will fix it.
Added support for armv8 platform flavours as follows: - PLATFORM = ls-ls1043ardb - PLATFORM = ls-ls1046ardb Signed-off-by: Sumit Garg <sumit.garg@nxp.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Added support for armv8 platform flavours as follows:
Signed-off-by: Sumit Garg sumit.garg@nxp.com