Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug] Webapp: Fix the third-party provider settings #7602

Open
sushidave opened this issue Jul 6, 2024 · 9 comments
Open

🐛 [Bug] Webapp: Fix the third-party provider settings #7602

sushidave opened this issue Jul 6, 2024 · 9 comments
Assignees
Labels

Comments

@sushidave
Copy link
Member

sushidave commented Jul 6, 2024

🐛 Bugreport

A few things need to be fixed on the account settings page for embedded content of third-party providers:

1) Options

  • Selecting "No thanks" (= don't display content) should result in the content not being displayed
  • Selecting "Sure" (= display content) should result in the content being displayed
    (...and not the other way round.)

2) List of providers
It says "Here is the list of third-party providers whose content can be displayed as third-party code, e.g. in the form of embedded videos." but the list of providers is missing.

  • add the list
    or
  • remove the text

3) Design
Add a margin between the buttons and the text below, see screenshot.

Bildschirmfoto 2024-07-22 um 14 47 43
@sushidave sushidave added bug Something isn't working project: helfa.social labels Jul 6, 2024
@Tirokk Tirokk changed the title 🐛 [Bug] Fix the third-party provider settings 🐛 [Bug] Webapp: Fix the third-party provider settings Jul 22, 2024
@Tirokk Tirokk moved this to Sprint Backlog in Kanban Board Ocelot-Social Software Jul 22, 2024
@Tirokk Tirokk added the good first issue Good for newcomers label Jul 22, 2024
@Jatan88
Copy link

Jatan88 commented Jul 30, 2024

Hello there, I am interested in working on this issue. Can you please assign it to me?

@Tirokk
Copy link
Member

Tirokk commented Jul 30, 2024

Yes you are welcome to work on it @Jatan88 🙏🏼

Great that you want to take on this task! 🤗
I assigned you to this issue.

I took care of your invitation to join our community as a volunteer via an e-mail invitation that you can accept.

Our conversation runs over our discord server:
https://discord.gg/AJSX9DCSUA
Please use our chat channel to ping me ( @wolle (Hamburg)#8013 ) or another mentor.

!!!
Please don’t compare from your fork to this repository in case, because the publish action will fail, because of permission problems with the credentials.
Please do not compare from your fork to this repository, as the CI will fail due to authorization issues with the credentials.
Simply push your branch directly into our repo and compare it with the master.
If you accept the invitation you have the right to do so. 😉

@Jatan88
Copy link

Jatan88 commented Jul 30, 2024

Thanks @Tirokk , I will start working on the issue from now on.

@Tirokk
Copy link
Member

Tirokk commented Jul 31, 2024

I wrote to the developer who developed the code at that time and try to clarify if the list is still necessary because videos of a lot more providers can be used now as far as I know.

Hope I get a quick answer and let you know.

@ogerly
Copy link
Member

ogerly commented Aug 1, 2024

Thanks @Tirokk , I will start working on the issue from now on.

Hello @Jatan88,

I have reviewed it this time, but I didn't build it.

  • There is a backend/public/providers.json file in the backend.
  • These are available for selection.
  • These are also the elements that can be integrated into the editor.
  • Users are given the option to enable or disable all elements.
  • If the user leaves everything as it is, YouTube videos and other embeddable content will be displayed normally.
  • However, if the user chooses to block certain third-party providers, these elements will no longer be embedded directly. Instead, a notice will be shown with the option to actively confirm and view the embedded content.
  • The file webapp/pages/settings/embeds.vue integrates this providers.json.
  • The issue is likely found here: backend/src/schema/resolvers/embeds/findProvider.ts.

@sushidave
Copy link
Member Author

sushidave commented Aug 19, 2024

@Jatan88
Hi Jatan,
Thanks very much for working on this issue!
I would like to check with you quickly if you were able to connect with the developers on Discord and if you need more information or some help. If you face any issues with the development, the software or the people, please let us know. We are very interested in finding possible obstacles and improving the process for developers, especially for contributors like you.
Looking forward to reading from you.
Cheers,
David

@Dibyajyoti1515
Copy link

Hello there, I am interested in working on this issue. Can you please assign it to me?

@Tirokk
Copy link
Member

Tirokk commented Oct 7, 2024

Yes you are welcome to work on it @Dibyajyoti1515 🙏🏼

Great that you want to take on this task! 🤗
I assigned you to this issue.

I took care of your invitation to join our community as a volunteer via an e-mail invitation that you can accept.

Our conversation runs over our discord server:
https://discord.gg/AJSX9DCSUA
Please use our chat channel to ping me ( @wolle (Hamburg)#8013 ) or another mentor.

!!!
Please don’t compare from your fork to this repository in case, because the publish action will fail, because of permission problems with the credentials.
Simply push your branch directly into our repo and compare it with the master.
If you accept the invitation you have the right to do so. 😉

@Dibyajyoti1515
Copy link

Update embeds.vue #7953

plese chack out this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Sprint Backlog
Development

No branches or pull requests

5 participants