Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no message when print done #26

Closed
KrisRux opened this issue Apr 21, 2020 · 3 comments
Closed

no message when print done #26

KrisRux opened this issue Apr 21, 2020 · 3 comments

Comments

@KrisRux
Copy link

KrisRux commented Apr 21, 2020

i don't receive the messago when print done but test and update function work correctly.

@mazamorac
Copy link

I've never received finished print job notifications, and progress notifications started failing every once in a while.
Looking in the octoprint log files, I see the startup message, and when it fails:

2020-04-22 16:09:32,768 - octoprint.plugin - ERROR - Error while calling plugin octobullet
Traceback (most recent call last):
File "/home/pi/git/OctoPrint/venv/local/lib/python2.7/site-packages/octoprint/plugin/__init__.py", line 224, in call_plugin
  result = getattr(plugin, method)(*args, **kwargs)
File "/home/pi/git/OctoPrint/venv/local/lib/python2.7/site-packages/octoprint_octobullet/__init__.py", line 241, in on_event
  path = os.path.basename(payload["file"])
KeyError: 'file'

My guess is that it's looking for the name of the file via a key "file" in a duct, and bombs (I use "file" in my status message config).

The call to getattr() should probably be wrapped in an exception handler. If I get a chance I might submit a fix.

The workaround would be to omit the {file} in the status message, at least. There may be others that error out too.

@scottrini
Copy link
Collaborator

Hey there! I actually just recently took over maintaining this plugin because I ran into this specific issue. The key in octoprint changed, so instead of file, it's now called name. I have a fork with this update applied: https://github.com/scottrini/OctoPrint-Pushbullet

I'm going to get this merged into this repo and get it tagged and bumped.

@scottrini
Copy link
Collaborator

Fixed in 0.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants