Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when using --variable option in create-release command without --deployto #10

Open
KennethBates opened this issue Jul 16, 2019 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@KennethBates
Copy link
Contributor

Prompted variables have their values supplied at deployment time, and not at release creation. However you can use the --variable=VALUE parameter in Octo.exe's create-release command, which will supply the value if you also have the --deployto parameter set in the same command. If you use the --variable option without the --deployto option, no error or warning is displayed, which it should.

Additionally, we should probably update the octo.exe help text to make this more clear. Currently it says

[Optional] Values for any prompted variables in the format Label:Value. For JSON values, embedded quotation marks should be escaped with a backslash.

One example of this common confusion that this change could have potentially prevented: https://secure.helpscout.net/conversation/904123519/47238?folderId=954335 (private link)

@KennethBates KennethBates added the kind/enhancement New feature or request label Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant