fix: expand tenant view output #174
Conversation
pkg/cmd/tenant/list/list.go
Outdated
|
|
||
| func getEnvironmentMap(client *client.Client) (map[string]string, error) { | ||
| environmentMap := make(map[string]string) | ||
| allEnvs, err := client.Environments.GetAll() |
There was a problem hiding this comment.
We should avoid GetAll. It does not scale. Is there any way of getting this information from another API?
There was a problem hiding this comment.
fair point, I can modify it to find all the ids it needs and call the query endpoint with a list
There was a problem hiding this comment.
Just out of curiosity, which endpoint can we use?
There was a problem hiding this comment.
we can filter by a list of id values
api/Spaces-1/environments?ids=Environments-1,Environments-282
pkg/cmd/tenant/list/list.go
Outdated
|
|
||
| func getProjectMap(client *client.Client) (map[string]string, error) { | ||
| projectMap := make(map[string]string) | ||
| allEnvs, err := client.Projects.GetAll() |
There was a problem hiding this comment.
We should avoid GetAll. It does not scale. Is there any way of getting this information from another API?
There was a problem hiding this comment.
agreed, in the api for all resources when you do client.Projects.Get() on the returned struct you can use the .GetAllPages() function to get all.
This change is to support filtering tenants by tag using
jqjson before:
json after:
TenantTagsfield is marked asomitemptyso an empty array ends up being left out. Previously we were ending up with the default values of an empty array in the json, making the contract more stable.table before:
table after:
