Fix: empty list errors #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects `project convert`, `tenant clone` and `tenant connect`
affects role select/add
benPearce1
commented
Jan 6, 2023
Comment on lines
-268
to
-273
| // if there are no options to render | ||
| if len(m.Options) == 0 { | ||
| // we failed | ||
| return "", errors.New("please provide options to select from") | ||
| } | ||
|
|
There was a problem hiding this comment.
this copy of the multi-select is specifically designed to allow adding new entries, an empty starting list should not be an error
benPearce1
commented
Jan 6, 2023
|
|
||
| "github.com/AlecAivazis/survey/v2" | ||
| "github.com/OctopusDeploy/cli/pkg/constants" | ||
| "github.com/OctopusDeploy/cli/pkg/surveyext" | ||
| ) | ||
|
|
||
| func MultiSelectMap[T any](ask Asker, message string, items []T, getKey func(item T) string, required bool) ([]T, error) { | ||
| if util.Empty(items) { | ||
| return nil, fmt.Errorf("%s - no options available", message) |
There was a problem hiding this comment.
by erroring with the original prompt, the user gets the context of the error
jbristowe
approved these changes
Jan 6, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #207
before:
after:
before:
after:
