-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create AWS account #45
Conversation
for _, match := range allMatches { | ||
if envName == match.Name { | ||
envIds = append(envIds, match.ID) | ||
continue loop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to think pretty hard to work out the logic here...
Perhaps it would be simpler just to do an ordinary loop with a break (and no continue-outer) and then just put an if statement at the end which says if(len(envIds) == 0) { envIds = envIds.Append(envName) }
if err != nil { | ||
f.Spinner().Stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, this spinner is getting a bit awkward, I wonder if we can do something to help with defer etc. I have no solutions at the moment, but it's something to think about in the background
if err != nil { | ||
return nil, err | ||
} | ||
itemIds := make([]string, 0, len(items)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could use util.SliceTransform here.
I'm unsure if we should though? How good is go at inlining lambdas?
No description provided.