feat: create AWS account #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borland
approved these changes
Aug 3, 2022
| for _, match := range allMatches { | ||
| if envName == match.Name { | ||
| envIds = append(envIds, match.ID) | ||
| continue loop |
There was a problem hiding this comment.
I had to think pretty hard to work out the logic here...
Perhaps it would be simpler just to do an ordinary loop with a break (and no continue-outer) and then just put an if statement at the end which says if(len(envIds) == 0) { envIds = envIds.Append(envName) }
| if err != nil { | ||
| f.Spinner().Stop() |
There was a problem hiding this comment.
Hmmm, this spinner is getting a bit awkward, I wonder if we can do something to help with defer etc. I have no solutions at the moment, but it's something to think about in the background
| if err != nil { | ||
| return nil, err | ||
| } | ||
| itemIds := make([]string, 0, len(items)) |
There was a problem hiding this comment.
you could use util.SliceTransform here.
I'm unsure if we should though? How good is go at inlining lambdas?
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.