octopus config set interactive mode broken #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat wasn't already in the config file
borland
commented
Sep 20, 2022
| @@ -103,8 +103,8 @@ func promptMissing(ask question.Asker, key string) (string, string, error) { | |||
| } | |||
| key = k | |||
| } | |||
| // Deliberate reach-out to the global viper to ask it what is valid (localViper doesn't know much) | |||
| if !viper.InConfig(key) { | |||
There was a problem hiding this comment.
bug was that viper.InConfig would check if the key was specifically in the config file, rather than just being known to viper as a potentially valid key
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #82