First test fails for OneNote in E2E app

[joshgav]

When running all the tests for OneNote, the first test frequently fails. This seems to be because of a race condition between the API call and the two calls to complete OAuth authorization - that is, authorization hasn't completed in time for the first API call. Let's see how we can better wait on completed authorization. Perhaps this would be in the LiveAuthClient itself?

@peternied @ovenado

[peternied]

Shouldn't the connections objects know the state the authorization systems are in to wait/refresh until they can get the credentials for the request? Example of how this was done, https://github.com/OneDrive/onedrive-explorer-android/blob/master/onedriveaccess/src/main/java/com/microsoft/onedriveaccess/InterceptorFactory.java

[joshgav]

Need to think about this a bit more. I think the difference might be that we call loginSilent on each API call, allowing the underlying auth client to decide whether to get from cache or make a network call. In your example you call getSession() which I think would always be static.

The pattern we use is based on the pattern for ADAL recommended by @vibronet - call acquireTokenSilent every time and let the lib decide what to do.

Relevant source:
BaseODataContainer
LiveAuthDependencyResolver
ADALDependencyResolver