-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider migrating to SILE org and/or core #1
Comments
Specific proposal:
|
I am embarrassed... Really. First, this package is important to me (it's used everywhere in my book, and above all it's the key component in a "choose your own adventure"-like chapter, which would have been much harder without it1). It's one of the first I completed to what I considered a pretty satisfying state in the SILE 0.12.x era, and proposed in April 2022 as a PR - since the topic was mentioned in an issue, and in a (now removed) Wiki page. Now, countless rebase operations afterwards, the requests comes both too late and too soon. .. Too late... This package now has its life as a 3rd-party module... I could say: "No man ever steps in the same river twice"... But even though, this package is now also cluttered with technical debt and issues, in the SILE 0.14+ era...
Too soon... While it went to its "fireproof" in my book, that doesn't mean it's so clever...
Still, some good questions are raised...
Or 3rd-party packages would need a way to be tested against several versions of SILE and Lua... (Omikhleia/markdown.sile#26)
So I'd be using a forked version of my own package, not the one SILE would provide. Er. What's the point for anyone? But still, I feel embarrassed (and too tired to push my thought further, barely recovering from the sickness that struck me last week... Yeah, that was it, with the loss of smell and taste and all ^^ ;) Footnotes
|
I am personally of the opinion that while it is a good thing that this can be a third party package and I'm glad we hashed out the issues involved in making enough API surface area for this to work as an external package, this is actually a fundamental enough functionality that will be useful to enough other packages that it should be kept a little closer to SILE's core.
Would you consider one or both steps of moving this into the SILE org and publishing stable versions from the API key there; and secondarily re-splicing the code into the SILE core so it can be tested and refactored on the same release cycle?
Keep in mind that since 3rd party packages take precedence over core ones if any aspect of the core one was not to your liking you could continue to use the forked/3rd party one over the official/core one without anything different that what you're doing now.
The text was updated successfully, but these errors were encountered: