Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly implement highlight(mark)/insertions/deletions with styling support #110

Closed
Omikhleia opened this issue Feb 3, 2024 · 2 comments · Fixed by #112
Closed

Correctly implement highlight(mark)/insertions/deletions with styling support #110

Omikhleia opened this issue Feb 3, 2024 · 2 comments · Fixed by #112
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Omikhleia
Copy link
Owner

Omikhleia commented Feb 3, 2024

The current implementation for "highlight" a.k.a. "mark" (that is, =inline= in Markdown, {=inline=} in Djot -- additionally also supported as a .mark pseudo-class) , is just a placeholder (hard-coded to show the text in red, with a big FIXME TODO We'd need real support in the code.

What I'd want here is:

  • Some background color by default as fallback, now that we have "liners" spanning multiple lines (in SILE develop branch for 0.15 and likewise in sile-x.
  • Some style-enabled variant when used in resilient styling context, and the latter needs to be upgraded to accept:
    • Customizing the color via a style
    • Possibly to customize the rendering: rather than a rectangular box, use ptable.sile 's "rough" support in order use some sketchy variants (so as to make the text look as manually highlighted)
      • Needs support in ptable.sile for a rough highlight liner
      • Needs support in resilient.sile for a custom style
@Omikhleia Omikhleia added the enhancement New feature or request label Feb 3, 2024
@Omikhleia
Copy link
Owner Author

Omikhleia commented Feb 3, 2024

As for the "default fallback", perhaps it makes sense to propose to SILE's rules packages two easy additions:

  • a "highlight" "marked" liner (= background color below the text)
  • a "redacted" liner (= above the text and not rendering it)

EDIT: Scrap that. I'd need style-enabled versions of these anyway, so cannot avoid a resilient version eventually.

@Omikhleia
Copy link
Owner Author

But note that Djot's deletions and insertions where also kind of hard-coded fallbacks and would also need to be properly re-implemented.

@Omikhleia Omikhleia self-assigned this Feb 13, 2024
@Omikhleia Omikhleia changed the title Correctly implement highlight/mark with styling support Correctly implement highlight(mark)/insertions/deletions with styling support Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant