Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tx21 description refinements needed #284

Open
marv-engine opened this issue Oct 31, 2014 · 6 comments
Open

some tx21 description refinements needed #284

marv-engine opened this issue Oct 31, 2014 · 6 comments

Comments

@marv-engine
Copy link

Just capturing that the following changes/clarifications have to be made:

  1. liquidity bonus deferred
  2. Cancel (Actions=2,3,4) is invalid if no active tx21's affected
    • Also: for tx20, update/cancel are invalid if no active tx20
  3. move Action field to immediately after txtype field
  4. for Action=3, the amount fields are not validated
  5. for Action=4 (Cancel all), only one field follows - ecosystem
    • no currencies or amounts necessary

Edit: txversion=1 will support this msg layout with the ecosystem field

@marv-engine
Copy link
Author

We need to explicitly state when/how a sell order is filled, and no longer a candidate to match a new sell order - e.g. when the full amount for sale has been transferred.

@dexX7
Copy link
Member

dexX7 commented Nov 10, 2014

I think this is a broader issue. Due to the merging I can imagine there is no clear line and unfortunally it looks like as if an order isn't identifiable, because it loses it's id, once merged. At best I can think of a composition or a chain of transactions that points to an order. Because orders can also be partially filled and there might be overlaps, I'm not sure, if this can serve as unique idedntifier.

But if orders were trackable or fully identifiable, it's just a question of keeping track, so to speak, which seems doable.

@marv-engine
Copy link
Author

Per @zathras-crypto merging is still open for debate. We need to nail down all the details so coding and testing can be completed.

@dacoinminster
Copy link
Contributor

It would be good to specify that liquidity bonus is not in version 1, but I'm not aware of other open issues which are still being debated at this point.

@marv-engine
Copy link
Author

numbers 2, 4, and 5 should be explicitly stated in the spec.

@dexX7
Copy link
Member

dexX7 commented Nov 16, 2014

I agree, noticed this a few minutes ago, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants