-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some tx21 description refinements needed #284
Comments
We need to explicitly state when/how a sell order is filled, and no longer a candidate to match a new sell order - e.g. when the full amount for sale has been transferred. |
I think this is a broader issue. Due to the merging I can imagine there is no clear line and unfortunally it looks like as if an order isn't identifiable, because it loses it's id, once merged. At best I can think of a composition or a chain of transactions that points to an order. Because orders can also be partially filled and there might be overlaps, I'm not sure, if this can serve as unique idedntifier. But if orders were trackable or fully identifiable, it's just a question of keeping track, so to speak, which seems doable. |
Per @zathras-crypto merging is still open for debate. We need to nail down all the details so coding and testing can be completed. |
It would be good to specify that liquidity bonus is not in version 1, but I'm not aware of other open issues which are still being debated at this point. |
numbers 2, 4, and 5 should be explicitly stated in the spec. |
I agree, noticed this a few minutes ago, too. |
Just capturing that the following changes/clarifications have to be made:
Edit: txversion=1 will support this msg layout with the ecosystem field
The text was updated successfully, but these errors were encountered: