-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OmniSharp-Roslyn portable. #517
Comments
cc @DustinCampbell @hal-ler, I should dig up a list of other editor author's as well... |
We need to think about the problem domain. That problem domain is at it's core "editor intelligence", so our consumers are not developers, but instead editors that we're making smarter. So I like having a native executable, for editor author's the process to obtain OmniSharp is fairly straight forward. There are challenges, we need a way to stay in sync with the supported os graph of CoreClr. I'm sure we can automate this, or simplify it greatly. I'm not saying we shouldn't have a portable version, we should definitely have one that is portable. It's just obtaining the portable version would painful, and involve a ton of rework for each and every editor to manage. The flow would be something like It's possible to script out that work, but now we're back in the place of managing fetch script for It might be more work for OmniSharp itself, to have to build all the artifacts and have them ready. On the other hand the amount of effort on the Editor side is greatly simplified. It also shields the Editor Authors from the constant churn that's happening on the cli side, they don't have to know what a portable runtime is if they don't want to. |
What is the status of using portable apps with dotnet test? That would at least get rid of a lot of unnecessary maintenance. Having to only update a single project.json and build.cake with new runtimes (maybe even finding a way to synchronize the two) seems plausible. |
Is there a way to have some aliases in the project.json for the different frameworks, which the build script could parse to populate it's list automatically? Like |
Is my understanding correct that there is a single "runnable" TFM right now, meaning that shared platform and standalone builds are exclusive? |
This will be happening with #666. |
I'd like start a conservation of making
OmniSharp-Roslyn
portable.Pros:
OmniSharp-Roslyn
for different runtimes.dotnet
expand it's supported platforms list.Cons:
cli
locating and acquiring logic.The text was updated successfully, but these errors were encountered: