Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suppression of hidden messages to be configurable with a default to supress #1435

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Allow suppression of hidden messages to be configurable with a default to supress #1435

merged 2 commits into from
Apr 27, 2017

Conversation

bakakaba
Copy link
Contributor

…t to supress (#1429)

@dnfclas
Copy link

dnfclas commented Apr 27, 2017

@cruz82,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented Apr 27, 2017

@cruz82, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

cateyes99
cateyes99 approved these changes Apr 27, 2017
View reviewed changes
Copy link

@cateyes99 cateyes99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DustinCampbell
DustinCampbell requested changes Apr 27, 2017
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good! Could you make the requestd tweaks to the user-facing option? Otherwise, it's in good shape.

package.json Outdated
"csharp.suppressHiddenMessages": {
"type": "boolean",
"default": true,
"description": "Suppress hidden messages from being shown."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we go with "hidden diagnostics" rather than "hidden messages".

  • setting name: csharp.suppressHiddenDiagnostics
  • description: Suppress 'hidden' diagnostics (such as 'unnecessary using directives') from appearing in the editor or the Problems pane

@DustinCampbell DustinCampbell changed the title Allow suppression of hidden messages to be configurable with a defaul… Allow suppression of hidden messages to be configurable with a default to supress Apr 27, 2017
@bakakaba
Copy link
Contributor Author

@DustinCampbell, updated the setting name and the description.
Thanks.

DustinCampbell
DustinCampbell approved these changes Apr 27, 2017
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks!

@DustinCampbell DustinCampbell merged commit 64d1034 into dotnet:master Apr 27, 2017
@DustinCampbell
Copy link
Member

I'm planning to release a new C# for VS Code beta later today or early tomorrow. That will have this setting in it.

@cateyes99 cateyes99 mentioned this pull request May 16, 2017
Closed
@pgolebiowski
Copy link

@cruz82 You're awesome, man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cateyes99 cateyes99 cateyes99 approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bakakaba @dnfclas @DustinCampbell @pgolebiowski @cateyes99