Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running and debugging NUnit tests #1760

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

dgileadi
Copy link
Contributor

I found that when I click the "run test" item on my NUnit test class, it wouldn't do anything. Turning up the log level showed me the call to the server:

[dbug]: OmniSharp.Middleware.LoggingMiddleware
        ************ Request ************
POST - /v2/runtest
************ Headers ************
Content-Type - application/json
************  Body ************
{
  "FileName": "/Users/gileadis/Projects/Armor of God/Unity/Armor of God/Assets/Scripts/Editor/TypewriterTextTests.cs",
  "MethodName": "TypewriterTextTests.TestComplete",
  "TestFrameworkName": "xunit"
}

Notice the TestFrameworkName of xunit, even though I'm running an NUnit test. Digging through the code pointed me to this typo. I'm not certain it's the culprit, but it seems worth fixing in any case.

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch!

@DustinCampbell
Copy link
Member

This likely fixes #1635.

@DustinCampbell DustinCampbell changed the title Fix typo Fix running and debugging NUnit tests Sep 15, 2017
@DustinCampbell DustinCampbell merged commit ababa13 into dotnet:master Sep 15, 2017
@dgileadi dgileadi deleted the fix-nunit-name branch September 15, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants