Provide more granular file change events based on VS Code file create/delete events #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2017
DustinCampbell
changed the title
DustinCampbell
requested changes
Oct 24, 2017
src/features/changeForwarding.ts
Outdated
| let d1 = watcher.onDidCreate(onFileSystemEvent(FileChangeType.Create)); | ||
| // In theory we don't need to subscribe to "change" notifications | ||
| // because we already get them through the buffer update request | ||
| //let d2 = watcher.onDidChange(onFileChange); |
There was a problem hiding this comment.
Maybe move this to be last so that there isn't a gap between d1 and d3?
src/omnisharp/protocol.ts
Outdated
| @@ -417,6 +417,17 @@ export interface PackageDependency { | |||
| Name: string; | |||
| Version: string; | |||
| } | |||
|
|
|||
| export interface FilesChangedRequest extends Request{ | |||
| ChangeType: FileChangeType | |||
There was a problem hiding this comment.
You called this FileChangeType in your omnisharp-roslyn PR. So this probably doesn't actually work. 😄
There was a problem hiding this comment.
Updated the member name in the other PR.
DustinCampbell
approved these changes
Oct 25, 2017
|
@rchande: Out of curiosity, have you tested that this works? I'm curious since the protocol didn't match omnisharp-roslyn at first. |
|
@DustinCampbell I did test this--verified in the debugger that we were getting hit for both create and delete events. |
jrieken
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/delete events