Map all symbol kinds to vscode.SymbolKinds

[craig006]

Fixes this issue:
#1907

[rchande]

Looks good to me. Thanks for your contribution!

[rchande]

@akshita31 Before we merge this, do you mind pulling the branch and verifying the behavior?

[TheRealPiotrP]

@rchande how do we add a test for this behavior?

[rchande]

@TheRealPiotrP Well, if we had per-feature unit tests, that would be a good place to add these tests. However, we're doing approximately the same mapping in completionItemProvider.ts, so this might be a good time to extract out a common helper and add tests for it in a new file under unitTests. @craig006 Any interest in doing that work, too?

[akshita31]

@rchande The type "Delegate" is missing here. It is not present in SymbolKind as well. Should we go ahead and add that ?

[rchande]

@akshita31 Sure. What icon does it show up with now? Note that there's no VSCode icon for "Delegate" https://code.visualstudio.com/docs/extensionAPI/vscode-api#SymbolKind

[akshita31]

Currently it is defaulting to a class type, hence we are getting a symbol for the class only.

[akshita31]

The change does make the functionality a lot better. @craig006 could you add a case for Delegate as well with the return type as SymbolKind.Method ?

[DustinCampbell]

Assuming @craig006 doesn't have the time at the moment, can we take this PR and make the change @akshita31 suggested separately?

[rchande]

Thanks for your contribution @craig006! This has been merged.