Check for undefined #3678
Merged
Check for undefined #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
approved these changes
Mar 18, 2020
ajaybhargavb
approved these changes
Mar 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #3678 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 59 59
Lines 1589 1589
Branches 89 89
=======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
NTaylorMullen
approved these changes
Mar 18, 2020
JoeRobich
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showWarningMessagereturns undefined in the case that the selection from the message is to press thexinstead of one of the 'option' buttons, which causes an Error without some sort of check.