Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support async completion #4116

Merged
merged 5 commits into from
May 17, 2021
Merged

Support async completion #4116

merged 5 commits into from
May 17, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Oct 16, 2020

@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #4116 (486c831) into master (0d501a4) will increase coverage by 17.25%.
The diff coverage is 100.00%.

❗ Current head 486c831 differs from pull request most recent head 0e83f1a. Consider uploading reports for the commit 0e83f1a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4116       +/-   ##
===========================================
+ Coverage   68.76%   86.02%   +17.25%     
===========================================
  Files         109       60       -49     
  Lines        4325     1860     -2465     
  Branches      756      215      -541     
===========================================
- Hits         2974     1600     -1374     
+ Misses       1153      200      -953     
+ Partials      198       60      -138
Flag Coverage Δ
integration ∅ <ø> (∅)
unit 86.02% <100.00%> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/omnisharp/options.ts 94.56% <100.00%> (-3.31%) ⬇️
src/omnisharp/protocol.ts 79.57% <100.00%> (-7.84%) ⬇️
src/NetworkSettings.ts 37.50% <0.00%> (-62.50%) ⬇️
src/utils/getDotnetInfo.ts 19.04% <0.00%> (-49.14%) ⬇️
src/observers/TelemetryObserver.ts 76.11% <0.00%> (-20.90%) ⬇️
src/observers/BaseLoggerObserver.ts 60.00% <0.00%> (-20.00%) ⬇️
src/packageManager/PackageError.ts 83.33% <0.00%> (-16.67%) ⬇️
src/packageManager/proxy.ts 42.10% <0.00%> (-15.79%) ⬇️
src/observers/OptionProvider.ts 57.14% <0.00%> (-14.29%) ⬇️
src/common.ts 56.17% <0.00%> (-12.36%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea20d08...0e83f1a. Read the comment docs.

@333fred 333fred marked this pull request as ready for review April 25, 2021 03:15
333fred added 2 commits May 6, 2021 23:43
@333fred
Merge remote-tracking branch 'upstream/master' into async-completion
96a3dd3 
* upstream/master:
  Define newly added referencesCodeLens.filteredSymbols option in package.json
  Add option for additional filters for codelens suppression
@333fred
Merge branch 'master' into async-completion
d506d63
@333fred
Copy link
Member Author

333fred commented May 7, 2021

@JoeRobich @filipw for review.

333fred
333fred commented May 7, 2021
View reviewed changes
src/omnisharp/protocol.ts Outdated Show resolved Hide resolved
@333fred
Copy link
Member Author

333fred commented May 16, 2021

@filipw could you take a look? It'd be good to get this in.

filipw
filipw approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! ✨

@JoeRobich JoeRobich merged commit f1461bd into dotnet:master May 17, 2021
@333fred 333fred deleted the async-completion branch May 17, 2021 16:00
@333fred 333fred mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@333fred @JoeRobich @filipw