Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only suppress file changed notifications for C# files #4230

Merged
merged 3 commits into from
Nov 27, 2020

Conversation

filipw
Copy link
Contributor

@filipw filipw commented Nov 23, 2020

This is a follow up to #4178

We should only suppress events for C# code files, not for files such as .csproj, .editorconfig or assets files, as it causes OmniSharp to go stale after changes are done in those files.

@filipw filipw requested review from JoeRobich and 333fred November 23, 2020 13:38
@filipw filipw changed the title only suppress file notifications for C# files only suppress file changed notifications for C# files Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #4230 (5c63c42) into master (8f7b3d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4230   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
integration ?
unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7b3d2...5c63c42. Read the comment docs.

src/features/changeForwarding.ts Outdated Show resolved Hide resolved
src/features/changeForwarding.ts Show resolved Hide resolved
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one const suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants