Allowing arm64 macOS to debug dotnet projects #4288

arthurlockman · 2020-12-11T15:43:02Z

This commit removes the bit of code that was preventing the .net debugger from starting on Apple Silicon.
I've added a warning message that indicates that you might see unexpected issues when running this way.
This should start working once macOS 11.1 is released next week. (See dotnet/runtime#44958 for more details)

Issue dotnet#4277 This commit removes the bit of code that was preventing the .net debugger from starting on Apple Silicon. I've added a warning message that indicates that you might see unexpected issues when running this way. This should start working once macOS 11.1 is released next week. (See dotnet/runtime#44958 for more details)

codecov · 2020-12-11T17:24:07Z

Codecov Report

Merging #4288 (a01fca4) into master (accb074) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4288   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60

Flag	Coverage Δ
integration	`?`
unit	`85.99% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update accb074...a01fca4. Read the comment docs.

gregg-miskelly

You are definitely welcome to do this now if you like, but according to this comment this scenario will not work. So it probably makes sense for that to be resolved before this is merged.

gregg-miskelly · 2020-12-11T17:44:48Z

src/coreclr-debug/activate.ts

@@ -43,6 +43,9 @@ async function checkForInvalidArchitecture(platformInformation: PlatformInformat
        else if (platformInformation.architecture !== "x86_64") {
            if (platformInformation.isWindows() && platformInformation.architecture === "x86") {
                eventStream.post(new DebuggerPrerequisiteWarning(`[WARNING]: x86 Windows is not currently supported by the .NET Core debugger. Debugging will not be available.`));
+            } else if (platformInformation.isMacOS() && platformInformation.architecture === "arm64") {


This isn't enough - the debugger will still not download. You can likely address that by adding the following to package.json:

{ "id": "Debugger", "description": ".NET Core Debugger (macOS / x64)", "url": "https://download.visualstudio.microsoft.com/download/pr/6f481c2a-74a8-41cc-a115-f2d059242062/96e3d82b95ff1375347fedf0f5c7d4e7/coreclr-debug-osx-x64.zip", "fallbackUrl": "https://vsdebugger.blob.core.windows.net/coreclr-debug-1-23-8/coreclr-debug-osx-x64.zip", "installPath": ".debugger", "platforms": [ "darwin" ], // Line 275 of package.json -- Add 'arm64' "architectures": [ "x86_64", "arm64" ], "binaries": [ "./vsdbg-ui", "./vsdbg" ], "installTestPath": "./.debugger/vsdbg-ui", "integrity": "6BAA9A20DAA71018B9912A3E2A48C52A273ADC2E70F7101C12F688F397AD16D8" },

Alright, fixed that.

dnfadmin · 2020-12-11T17:56:01Z

All CLA requirements met.

arthurlockman · 2020-12-11T17:58:09Z

You are definitely welcome to do this now if you like, but according to this comment this scenario will not work. So it probably makes sense for that to be resolved before this is merged.

Yeah, I've been following along with that thread. It looks like it'll let you debug and hit breakpoints, but it'll crash if you try to do a single step. So it seems like it's half-working.

gregg-miskelly · 2020-12-11T18:06:17Z

Yeah, I've been following along with that thread. It looks like it'll let you debug and hit breakpoints, but it'll crash if you try to do a single step. So it seems like it's half-working.

I don't have a device to play with, but I believe Jan is talking about a single step at an architectural level (setting the single step flag on the processor), which it probably used for way more than just stepping. My guess is that it is more like 99.9% broken then half working :)

gregg-miskelly · 2020-12-11T18:11:53Z

To make sure, with these changes were you able to confirm that with these changes the debugger is successfully download and you can at least use 'Start Without Debugging' on the target app?

arthurlockman · 2020-12-11T18:20:12Z

To make sure, with these changes were you able to confirm that with these changes the debugger is successfully download and you can at least use 'Start Without Debugging' on the target app?

Could you point me to how I could get tests to run with the Apple Silicon build of VS code? It's currently only on the 1.53.0-exploration build. I'm not that familiar with how the test framework works for VS extensions.

gregg-miskelly · 2020-12-11T18:53:26Z

@arthurlockman I believe you can just test this manually.

Follow these instructions to launch an "experiment instance" of VS Code using your locally built extension.
In the experimental instance, open a folder with a hello world C# project
The debugger should automatically download and your new warning should get printed.
You can then launch the project using "Start without debugging"

arthurlockman · 2020-12-11T19:20:53Z

@gregg-miskelly alright, got it working.

The debugger successfully installs with the warning I put in:

Then the debugger starts and crashes (as expected):

Run without debugging works successfully!

gregg-miskelly · 2020-12-11T19:23:33Z

Thanks for doing this! I will merge this once the CI completes.

arthurlockman · 2020-12-11T19:24:59Z

No problem! Glad I could help!

lutzroeder · 2023-03-18T17:39:50Z

package.json

@@ -273,7 +273,8 @@
        "darwin"
      ],
      "architectures": [
-        "x86_64"
+        "x86_64",
+        "arm64"


@arthurlockman @gregg-miskelly do you have some context why -x64.zip is installed for arm64?

In order to debug x64 processes on an M1

gregg-miskelly requested changes Dec 11, 2020

View reviewed changes

Adding arm64 to debug architectures

a01fca4

gregg-miskelly approved these changes Dec 11, 2020

View reviewed changes

gregg-miskelly merged commit 7d7b69d into dotnet:master Dec 11, 2020

arthurlockman deleted the feature/dotnetDebugOnAppleSilicon branch December 12, 2020 01:52

lutzroeder reviewed Mar 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allowing arm64 macOS to debug dotnet projects #4288

Allowing arm64 macOS to debug dotnet projects #4288

arthurlockman commented Dec 11, 2020

codecov bot commented Dec 11, 2020 •

edited

Loading

gregg-miskelly left a comment

gregg-miskelly Dec 11, 2020

arthurlockman Dec 11, 2020

dnfadmin commented Dec 11, 2020 •

edited

Loading

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020 •

edited

Loading

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

lutzroeder Mar 18, 2023

gregg-miskelly Mar 18, 2023

Allowing arm64 macOS to debug dotnet projects #4288

Allowing arm64 macOS to debug dotnet projects #4288

Conversation

arthurlockman commented Dec 11, 2020

codecov bot commented Dec 11, 2020 • edited Loading

Codecov Report

gregg-miskelly left a comment

Choose a reason for hiding this comment

gregg-miskelly Dec 11, 2020

Choose a reason for hiding this comment

arthurlockman Dec 11, 2020

Choose a reason for hiding this comment

dnfadmin commented Dec 11, 2020 • edited Loading

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020 • edited Loading

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

gregg-miskelly commented Dec 11, 2020

arthurlockman commented Dec 11, 2020

lutzroeder Mar 18, 2023

Choose a reason for hiding this comment

gregg-miskelly Mar 18, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 11, 2020 •

edited

Loading

dnfadmin commented Dec 11, 2020 •

edited

Loading

gregg-miskelly commented Dec 11, 2020 •

edited

Loading