Handle ProcessPicker via resolveDebugConfiguration #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code commands are limited to only being able to have a single output. We will handle having an empty processId and show the dialog for ProcessPicker in resolveDebugConfigurationWithSubstitutedVariables. We need multiple outputs to handle the latest macOS on Apple M1. For Apple Silicon M1 (ARM64), we need to determine if we need to use the x86_64 or arm64 debugger. We are able to detect if the process is using S_TRANSLATED using the ps commandline with 'flags', if it is set with 0x20000, it is emulated.
WardenGnaw
commented
Apr 20, 2021
Migrate remoteProcessPicker to also be in resolve configuration Handle 'clr' type for remote process picking. Addressing PR issues. Added comment about 0x20000
|
Tested:
|
gregg-miskelly
approved these changes
Apr 20, 2021
gregg-miskelly
approved these changes
Apr 20, 2021
This was referenced Jun 10, 2021
dibarbet
pushed a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Jun 8, 2023
Clean up double debugConfigurationProvider # Why When adding support for the new attach to process drop down, a secondary debugConfigurationProvider was created instead of extending off of the existing one. Related PR: dotnet#4509 # Changes This PR refactors DebugConfigurationProvider.ts into two classes. The new `BaseVsDbgConfigurationProvider` (originally the `DotnetDebugConfigurationProvider`) will be used for resolving the debug configuration for the debug adapter without any workspace information. Providers that will provide initial configurations can extend off of this base class, such as the `DotnetWorkspaceConfigurationProvider` (originally the `CSharpConfigurationProvider`) which is used by the Omnisharp and Roslyn LSP. DotnetWorkspaceConfigurationProvider uses IWorkspaceDebugInformationProvider to provide initial configurations. Other notes: - Also ran formatting on configurationProvider.ts because the open brace style was mixed. - Also removed DevCertCreationFailure # Testing I validated: - [x] `dotnet.generateAssets` works. - [x] F5 debug with no .vscode will generate assets. - [x] Web launch will still ask for cert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code commands are limited to only being able to have a single output.
We will handle having an empty processId and show the dialog for
ProcessPicker in resolveDebugConfigurationWithSubstitutedVariables.
We need multiple outputs to handle the latest macOS on Apple M1.
For Apple Silicon M1 (ARM64), we need to determine if we need to use the
x86_64 or arm64 debugger. We are able to detect if the process is using
S_TRANSLATED using the ps commandline with 'flags', if it is set with
0x20000, it is emulated.