-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debugger packages to 1.23.14 #4672
Merged
gregg-miskelly
merged 5 commits into
dotnet:master
from
auott:dev/auott/updateCSharpExt
Jul 21, 2021
Merged
Update debugger packages to 1.23.14 #4672
gregg-miskelly
merged 5 commits into
dotnet:master
from
auott:dev/auott/updateCSharpExt
Jul 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add win-arm64 package.
@auott Could you add an entry to the changelog for this? |
Can you also fix up the logic in https://github.com/OmniSharp/omnisharp-vscode/blob/5497895b44c4ecc625cd3d1241528f145ac7158b/src/coreclr-debug/activate.ts#L40-L66 |
Update changelog Fix activation logic to handle windows arm64 (and cleanup older logic).
auott
force-pushed
the
dev/auott/updateCSharpExt
branch
from
July 20, 2021 22:46
a624d6f
to
84f8115
Compare
WardenGnaw
approved these changes
Jul 20, 2021
JoeRobich
approved these changes
Jul 20, 2021
gregg-miskelly
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
gregg-miskelly
approved these changes
Jul 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds the win10-arm64 package.