Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminating some warnings when building the hello world app #333

Open
mcginnie opened this issue Apr 16, 2023 · 0 comments
Open

Eliminating some warnings when building the hello world app #333

mcginnie opened this issue Apr 16, 2023 · 0 comments

Comments

@mcginnie
Copy link

mcginnie commented Apr 16, 2023 •
edited
Loading

A couple of change to declarations to remove the unsigned/signed comparison warnings on the demo or blank application!

Lines 2709, 2721, 2733 int -> std::size_t

Line 3533 size_t -> int32_t

Line 3611 has nTextEntryCursor < sTextEntryString.size() so maybe static_caststd::size_t(nTextEntryCursor) < sTextEntryString.size()? This also seems to add several hundred FPS on the blank app!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcginnie