Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Latest published version is 1.0.4 #25

Open
1 task done
roman-utila opened this issue Mar 2, 2023 · 5 comments
Open
1 task done

[Bug]: Latest published version is 1.0.4 #25

roman-utila opened this issue Mar 2, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@roman-utila
Copy link

What happened?

Currently if you run go get https://github.com/OneSignal/onesignal-go-api you get the 1.0.4 version.

This version has a wrong interface for the CreateNotification request. It includes the Tag key instead of the Filters array.

When will a new version be out? this is blocking us from evaluating one signal

Steps to reproduce?

run `go get https://github.com/OneSignal/onesignal-go-api` in a golang project

What did you expect to happen?

I expected to get the files as they are in the master branch

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@roman-utila roman-utila added the bug Something isn't working label Mar 2, 2023
@icobani
Copy link

icobani commented Mar 27, 2023

Hello i have same problem.

@icobani
Copy link

icobani commented Jun 7, 2023

is there any progress ?

@fabiocody
Copy link

fabiocody commented Jun 21, 2023

Also, in version 1.0.4, NewNotification sets isIos to true for no reason

@djames-bloom
Copy link

I was also running into this issue, you have to specifically select the /v2 package version, otherwise, you will only be able to pull up to v1.0.4.

go get -u github.com/OneSignal/onesignal-go-api/v2

@icobani
Copy link

icobani commented Nov 6, 2023

change all import with

github.com/OneSignal/onesignal-go-api/v2

in all code

go mod tidy
go mod vendor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants