feat: add support for ocsp reason code suspended #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r invalid OCSP reason code
… DID document is signed but is found by an OCSP with an invalid reasoncode" for v3
superical
reviewed
Nov 26, 2024
| @@ -40,7 +40,7 @@ export type DidSignedIssuanceStatusArray = Static<typeof DidSignedIssuanceStatus | |||
| * OCSP response | |||
| */ | |||
|
|
|||
| export const ValidOcspReasonCode = Number.withConstraint((n) => n >= 0 && n <= 10 && n != 7); | |||
| export const ValidOcspReasonCode = Number.withConstraint((n) => [1, 2, 3, 4, 5, 6, 8, 9, 10, 1001].includes(n)); | |||
There was a problem hiding this comment.
I was just thinking, would this be simpler and still work?
export const ValidOcspReasonCode = Number.withConstraint((n) => Object.values(OcspResponderRevocationReason).includes(n));
This will need to import OcspResponderRevocationReason from revocation.types.ts into this file though. But what you have works too!
There was a problem hiding this comment.
Another thing is, n >= 0 && n <= 10 && n != 7 includes 0 but [1, 2, 3, 4, 5, 6, 8, 9, 10, 1001] doesn't. So maybe need to add 0 if we prefer listing out the numbers.
There was a problem hiding this comment.
Good catch!
I will follow your suggestion as it is cleaner
….type.ts Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
superical
approved these changes
Nov 26, 2024
chershentan
deleted the
feat/add-support-for-ocsp-reason-code-suspended
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To support the new reason code
1001which represents thesuspendeddocument status on OCSP responderChanges
ValidOcspReasonCodeto validate reason code1001OcspResponderRevocationReasonto returnSUSPENDEDfor reason code1001