Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Do not crash/error if Redis is unreachable for request limits #135

Open
arkocal opened this issue May 21, 2019 · 7 comments
Open

Do not crash/error if Redis is unreachable for request limits #135

arkocal opened this issue May 21, 2019 · 7 comments
Assignees
Labels
discussion enhancement Improvement of existing functionality

Comments

@arkocal
Copy link
Member

arkocal commented May 21, 2019

It is possible to achieve High Availability in Redis by master-slave replication, but most likely the costs of operating replicas is not worth for the short unexpected downtimes. I thinks it is better to temporarily disable rate limits by skipping the queries when Redis is not reachable. This way, we can offer HA in frontend, even when we don't in Redis with minimal changes in operation.

@arkocal arkocal added enhancement Improvement of existing functionality discussion labels May 21, 2019
@oguzcankirmemis
Copy link
Member

You mean queries will be still done but if frontend can't reach to redis it ignores the query?

@arkocal
Copy link
Member Author

arkocal commented May 21, 2019

Yes, precisely.

@oguzcankirmemis
Copy link
Member

I should also verify the redis code, that it works the way we expect, I will take a look at this while I do that

@wagmarcel
Copy link
Member

But redis is also used by mqtt gateway to store Tokens and will be used in future by wss.

@arkocal
Copy link
Member Author

arkocal commented May 21, 2019

From a scalibility perspective, it is better to use a seperate redis instance for that purpose.

See the first bullet list in Chapter 10.2 in Redis in Action: https://redislabs.com/ebook/part-3-next-steps/chapter-10-scaling-redis/10-2-scaling-writes-and-memory-capacity/

@arkocal
Copy link
Member Author

arkocal commented May 21, 2019

In case seperating the instances is not necessary, they can also use a single redis with HA, but I think it is better to have the option not to depend on Redis HA from the front end, it would not cause any problems when redis is also replicated, which would be useful/necessary for wss.

@oguzcankirmemis
Copy link
Member

#202 should be able to skip redis if it is not reachable, meaning it will allow the request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion enhancement Improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants