Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.17.0 🎉 #407

Merged
merged 109 commits into from
Nov 10, 2024
Merged

v0.17.0 🎉 #407

merged 109 commits into from
Nov 10, 2024

Conversation

simonmicro
Copy link
Member

No description provided.

@simonmicro simonmicro added 📜 documentation This adds / changes the documentation 🎉 release This PR / issue impacts the current release of the OS src/osw-config Stuff for the web UI / configuration options for the user labels Oct 6, 2024
@simonmicro simonmicro self-assigned this Oct 6, 2024
RuffaloLavoisier and others added 4 commits October 7, 2024 00:55
- init value, method proto type, structure style
- for compatible from upload v3 and download v3
- downgrade artifact plugin
- fix path for binary file
@RuffaloLavoisier RuffaloLavoisier self-requested a review October 7, 2024 06:58
RuffaloLavoisier and others added 5 commits October 7, 2024 21:25
Because this will assign potentially a lot of additional code changes to only the pipeline triggerer.
Example: Multiple deves are working on the same PR. One of them merges it in the end (or better
a maintainer of us) and "commits" all the changes. This will cause in Git blame to only show him up.
Also, filtering based on the actions email will not work anymore.
Furthermore, people signing commits (like me) will cause a lot of unverified commits to pop up.

This reverts commit 22e3bfa.
@simonmicro
Copy link
Member Author

waits for #405

Copy link
Member

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

emulator/src/Emulator.cpp Show resolved Hide resolved
include/.gitignore Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchface.cpp Show resolved Hide resolved
Copy link
Member

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good To me 😄

@simonmicro simonmicro merged commit 2703982 into master Nov 10, 2024
@simonmicro simonmicro mentioned this pull request Nov 10, 2024
@simonmicro simonmicro linked an issue Nov 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📜 documentation This adds / changes the documentation src/core src/osw-app This PR / issue impacts the current release of the OS src/osw-config Stuff for the web UI / configuration options for the user ⭐ enhancement New feature or request 🎉 release This PR / issue impacts the current release of the OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watchfaces count bug
4 participants