Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix code style workflows user name #410

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

RuffaloLavoisier
Copy link
Member

fix code style info -> real uer info

@RuffaloLavoisier RuffaloLavoisier self-assigned this Oct 9, 2024
@RuffaloLavoisier RuffaloLavoisier merged commit 22e3bfa into develop Oct 9, 2024
108 checks passed
@RuffaloLavoisier RuffaloLavoisier deleted the fix_astyle branch October 9, 2024 04:17
simonmicro added a commit that referenced this pull request Oct 9, 2024
Because this will assign potentially a lot of additional code changes to only the pipeline triggerer.
Example: Multiple deves are working on the same PR. One of them merges it in the end (or better
a maintainer of us) and "commits" all the changes. This will cause in Git blame to only show him up.
Also, filtering based on the actions email will not work anymore.
Furthermore, people signing commits (like me) will cause a lot of unverified commits to pop up.

This reverts commit 22e3bfa.
@simonmicro
Copy link
Member

I'll revert this...

  • Because this will assign potentially a lot of additional code changes to only the pipeline triggerer. Example: Multiple deves are working on the same PR. One of them merges it in the end (or better a maintainer of us) and "commits" all the changes.
    *This will cause in Git blame to only show him up.
  • Also, filtering based on the actions email will not work anymore.
  • Furthermore, people signing commits (like me) will cause a lot of unverified commits to pop up.

simonmicro added a commit that referenced this pull request Oct 9, 2024
Because this will assign potentially a lot of additional code changes to only the pipeline triggerer.
Example: Multiple deves are working on the same PR. One of them merges it in the end (or better
a maintainer of us) and "commits" all the changes. This will cause in Git blame to only show him up.
Also, filtering based on the actions email will not work anymore.
Furthermore, people signing commits (like me) will cause a lot of unverified commits to pop up.

This reverts commit 22e3bfa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants