feature: impl hello and set name command with resp2 compatible #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelai
reviewed
Feb 3, 2023
src/pink/include/pink_conn.h
Outdated
| @@ -80,6 +80,9 @@ class PinkConn : public std::enable_shared_from_this<PinkConn> { | |||
| return is_reply_; | |||
| } | |||
|
|
|||
| std::string get_name() { return name_; } | |||
src/pika_admin.cc
Outdated
| return; | ||
| } | ||
|
|
||
| if (!strcasecmp(argv_[1].data(), "setname") && argv_.size() == 2) { |
There was a problem hiding this comment.
需要考虑下 处理setname foo bar dummy这种情况么
| res_.SetRes(CmdRes::kErrOther, "-NOPROTO unsupported protocol version"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
next_arg++;放在这里会更好一点，表示我们在这里处理完了一个参数。
| } | ||
|
|
||
| for (; next_arg < argv_.size(); ++next_arg) { |
There was a problem hiding this comment.
直接next_arg= 2 更好一点？作为读者，我们不必关心next_arg前面的处理逻辑。
src/pika_admin.cc
Outdated
| break; | ||
| default: | ||
| LOG(WARNING) << "unknown role" << host_role; |
There was a problem hiding this comment.
更多的信息能帮助定位哪个客户端发送的信息有误，例如connection 的ip 地址。
日志级别我任务info级别足够了，因为不是pika server 本身的错误。用户设置高的日志级别就是为了过滤掉信息
| INVALID_CONN, | ||
| }; | ||
|
|
||
| static AuthResult AuthenticateUser(const std::string& pwd, |
There was a problem hiding this comment.
考虑下如何跟auth cmd 复用，逻辑是相似的。
kernelai
changed the title
kernelai
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to fix those issue:
tips: this patch don't support RESP3 switch, maybe next feature to do :)