Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] stocks/ta/macd. -- Chart style in general #2963

Closed
jmaslek opened this issue Oct 21, 2022 · 7 comments · Fixed by #3312
Closed

[Bug] stocks/ta/macd. -- Chart style in general #2963

jmaslek opened this issue Oct 21, 2022 · 7 comments · Fixed by #3312
Assignees
Labels
bug Fix bug HACKTOBERFEST Hacktoberfest

Comments

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 21, 2022

The chart font sizes have been off, but this one I had to raise a bug on
Screen Shot 2022-10-20 at 8 24 49 PM

@github-actions github-actions bot added the bug Fix bug label Oct 21, 2022
@jmaslek
Copy link
Collaborator Author

jmaslek commented Oct 21, 2022

appears throughout menu. stoch is another example

@deeleeramone
Copy link
Contributor

deeleeramone commented Oct 23, 2022

I have legend location = best, and size as x-small, in my custom style sheet. It works for most of the MPL charts.

Screen Shot 2022-10-22 at 8 26 37 PM

@jmaslek
Copy link
Collaborator Author

jmaslek commented Oct 23, 2022

Yeah legend defaults to loc='best' on an axis. Could play with legend sizing, but on this one, just the font size could also be reduced. Some plots will likely just need more customizing than the generic style sheet.

@deeleeramone
Copy link
Contributor

Screen Shot 2022-10-22 at 8 37 31 PM

@deeleeramone
Copy link
Contributor

When the legend is hard-coded into the function, loc='best', doesn't get applied.

Screen Shot 2022-10-22 at 8 40 05 PM
Screen Shot 2022-10-22 at 8 41 32 PM

@jmaslek
Copy link
Collaborator Author

jmaslek commented Oct 23, 2022

the economy ones are intentionally put outside the axes

@deeleeramone
Copy link
Contributor

they should be full-width then, because the result is a shrinking chart canvas for every series that is included.

@JerBouma JerBouma added the HACKTOBERFEST Hacktoberfest label Oct 25, 2022
@andrewkenreich andrewkenreich self-assigned this Nov 4, 2022
@andrewkenreich andrewkenreich linked a pull request Nov 4, 2022 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug HACKTOBERFEST Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants