Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Export of stocks/load leaves you with unrecognizable Excel file names #3994

Closed
JerBouma opened this issue Jan 17, 2023 · 4 comments · Fixed by #3997
Closed

[Bug] Export of stocks/load leaves you with unrecognizable Excel file names #3994

JerBouma opened this issue Jan 17, 2023 · 4 comments · Fixed by #3997
Labels
bug Fix bug

Comments

@JerBouma
Copy link
Contributor

See the following, this is an export of multiple different tickers but it is not possible to recognize which is which:

image

The command stocks/candle does this better but downloading data via load is more efficient.

@github-actions github-actions bot added the bug Fix bug label Jan 17, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Jan 17, 2023

you can specify --export aapl.csv

@JerBouma
Copy link
Contributor Author

Hmm that solves the issue to some extend but adding the ticker to the string wouldn't be too hard either right? Candle does that too. It's mostly that the naming is off, e.g. candle produces 20230117_150713_stocks_AAPL.xlsx then I'd expect the same naming to be produced by load.

@jmaslek
Copy link
Collaborator

jmaslek commented Jan 17, 2023

So the load function is defined in the base controller, so it needs a more "abstract" naming convention. However, since the base controller does have the ticker, it should be doable, yes. And simple.

@deeleeramone
Copy link
Contributor

if using routines, you can set the filename to include the ticker by using the variable inputs, $ARGV[0]

load $ARGV[0] --export $ARGV[0]_ohlc.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
3 participants